invalid verification in `_arg_as_int()`

[ebouaziz@…]

the value returned by as_int() should be checked against None, otherwise we it is not possible to use 0 as value for some parameters as depth

example:

[[TitleIndex(Wiki, depth=0)]]

results in:

• WikiContext
• WikiCreole
• WikiDeletePage
• WikiEngine
• WikiFormatting
• WikiHtml
• WikiMacro
• WikiMacros
• WikiNewPage
• WikiPageName
• WikiPageNames
• WikiPhrases
• WikiProcessor
• WikiProcessors
• WikiRename
• WikiRestructuredText
• WikiRestructuredTextLinks
• WikiStart
• WikiWikiWeb

proposed fix:

trac/wiki/macros.py

@@ -915 +915 @@
 
 def _arg_as_int(val, key=None, min=None, max=None):
     int_val = as_int(val, None, min=min, max=max)
-    if not int_val:
+    if int_val is None:
         raise MacroError(tag_("Invalid macro argument %(expr)s",
                               expr=tag.code("%s=%s" % (key, val))
                                    if key else tag.code(val)))

[Ryan J Ollos]

Thanks for reporting. This is a regression in [14769] (#12370).

[Ryan J Ollos]

Fixed on 1.0-stable in [14850], merged to trunk in [14851].