ImageMacro: ValueError: invalid literal for int() with base 10: '10px'

[Ryan J Ollos]

From the logs:

[pid 10253 140015545095936] 2016-02-13 07:15:58,674 Trac[formatter] ERROR: Macro Image(icon_PyCharm.png, link=https://www.jetbrains.com/pycharm/, 35px, margin-right=10px, align=left) failed:
Traceback (most recent call last):
  File "/usr/local/virtualenv/1.1dev/lib/python2.7/site-packages/trac/wiki/formatter.py", line 798, in _macro_formatter
    return macro.ensure_inline(macro.process(args))
  File "/usr/local/virtualenv/1.1dev/lib/python2.7/site-packages/trac/wiki/formatter.py", line 375, in process
    text = self.processor(text)
  File "/usr/local/virtualenv/1.1dev/lib/python2.7/site-packages/trac/wiki/formatter.py", line 347, in _macro_processor
    text)
  File "/usr/local/virtualenv/1.1dev/lib/python2.7/site-packages/trac/wiki/macros.py", line 596, in expand_macro
    style[key] = ' %dpx' % int(val)
ValueError: invalid literal for int() with base 10: '10px'

[Ryan J Ollos]

We could also fix this macro argument issue:

[pid 3212 139730844530432] 2016-03-15 02:07:56,896 Trac[formatter] ERROR: Macro PageOutline(2-*) failed:
Traceback (most recent call last):
  File "/usr/local/virtualenv/1.1dev/lib/python2.7/site-packages/trac/wiki/formatter.py", line 802, in _macro_formatter
    return macro.ensure_inline(macro.process(args))
  File "/usr/local/virtualenv/1.1dev/lib/python2.7/site-packages/trac/wiki/formatter.py", line 379, in process
    text = self.processor(text)
  File "/usr/local/virtualenv/1.1dev/lib/python2.7/site-packages/trac/wiki/formatter.py", line 351, in _macro_processor
    text)
  File "/usr/local/virtualenv/1.1dev/lib/python2.7/site-packages/trac/wiki/macros.py", line 421, in expand_macro
    for d in depth.split('-', 1)]
ValueError: invalid literal for int() with base 10: '*'
[pid 3212 139730844530432] 2016-03-15 02:08:30,180 Trac[formatter] ERROR: Macro PageOutline(2+3) failed:
Traceback (most recent call last):
  File "/usr/local/virtualenv/1.1dev/lib/python2.7/site-packages/trac/wiki/formatter.py", line 802, in _macro_formatter
    return macro.ensure_inline(macro.process(args))
  File "/usr/local/virtualenv/1.1dev/lib/python2.7/site-packages/trac/wiki/formatter.py", line 379, in process
    text = self.processor(text)
  File "/usr/local/virtualenv/1.1dev/lib/python2.7/site-packages/trac/wiki/formatter.py", line 351, in _macro_processor
    text)
  File "/usr/local/virtualenv/1.1dev/lib/python2.7/site-packages/trac/wiki/macros.py", line 423, in expand_macro
    min_depth = max_depth = int(depth)
ValueError: invalid literal for int() with base 10: '2+3'

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t12370_image_macro_args.

[Ryan J Ollos]

Committed to 1.0-stable in [14769], merged to trunk in [14770].

[Ryan J Ollos]

Regression in [14769] reported in #12517.