Modify ↓
Opened 8 years ago
Closed 8 years ago
#12518 closed defect (fixed)
GitwebProjectsRepositoryProvider doesn't properly parse projects list file
Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
---|---|---|---|
Priority: | normal | Milestone: | 1.0.12 |
Component: | plugin/git | Version: | |
Severity: | normal | Keywords: | gitweb |
Cc: | Branch: | ||
Release Notes: |
Fixed incorrect parsing of projects list file by |
||
API Changes: | |||
Internal Changes: |
Description
The projects list format contains <repository path>
and <repository owner>
on a line, separated by whitespace. GitwebProjectsRepositoryProvider
seems to assume <repository owner>
is omitted.
Attachments (0)
Change History (3)
comment:1 by , 8 years ago
Release Notes: | modified (diff) |
---|
comment:2 by , 8 years ago
At least, unit tests doesn't run on Python 2.5.
python ./trac/test.py --skip-functional-tests /run/shm/8b3589370d1aa5b8d1bc82995d843ce2c2d1d789/py25-sqlite/tracopt/versioncontrol/git/tests/git_fs.py:686: Warning: 'with' will become a reserved keyword in Python 2.6 Traceback (most recent call last): File "./trac/test.py", line 600, in <module> unittest.main(defaultTest='suite') File "/usr/lib/python2.5/unittest.py", line 767, in __init__ self.parseArgs(argv) File "/usr/lib/python2.5/unittest.py", line 794, in parseArgs self.createTests() File "/usr/lib/python2.5/unittest.py", line 800, in createTests self.module) File "/usr/lib/python2.5/unittest.py", line 565, in loadTestsFromNames suites = [self.loadTestsFromName(name, module) for name in names] File "/usr/lib/python2.5/unittest.py", line 553, in loadTestsFromName test = obj() File "./trac/test.py", line 568, in suite import tracopt.versioncontrol.git.tests File "/run/shm/8b3589370d1aa5b8d1bc82995d843ce2c2d1d789/py25-sqlite/tracopt/versioncontrol/git/tests/__init__.py", line 16, in <module> from tracopt.versioncontrol.git.tests import PyGIT, git_fs File "/run/shm/8b3589370d1aa5b8d1bc82995d843ce2c2d1d789/py25-sqlite/tracopt/versioncontrol/git/tests/PyGIT.py", line 33, in <module> from tracopt.versioncontrol.git.tests.git_fs import GitCommandMixin File "/run/shm/8b3589370d1aa5b8d1bc82995d843ce2c2d1d789/py25-sqlite/tracopt/versioncontrol/git/tests/git_fs.py", line 686 with open(self.projects_list, 'w') as f: ^ SyntaxError: invalid syntax
comment:3 by , 8 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
Proposed changes in log:rjollos.git:t12518.