Edgewall Software

Opened 5 years ago

Closed 5 years ago

#12518 closed defect (fixed)

GitwebProjectsRepositoryProvider doesn't properly parse projects list file

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.12
Component: plugin/git Version:
Severity: normal Keywords: gitweb
Cc: Branch:
Release Notes:

Fixed incorrect parsing of projects list file by GitwebProjectsRepositoryProvider.

API Changes:
Internal Changes:


The projects list format contains <repository path> and <repository owner> on a line, separated by whitespace. GitwebProjectsRepositoryProvider seems to assume <repository owner> is omitted.

Attachments (0)

Change History (3)

comment:1 by Ryan J Ollos, 5 years ago

Release Notes: modified (diff)

Proposed changes in log:rjollos.git:t12518.

comment:2 by Jun Omae, 5 years ago

At least, unit tests doesn't run on Python 2.5.

python ./trac/test.py --skip-functional-tests 
/run/shm/8b3589370d1aa5b8d1bc82995d843ce2c2d1d789/py25-sqlite/tracopt/versioncontrol/git/tests/git_fs.py:686: Warning: 'with' will become a reserved keyword in Python 2.6
Traceback (most recent call last):
  File "./trac/test.py", line 600, in <module>
  File "/usr/lib/python2.5/unittest.py", line 767, in __init__
  File "/usr/lib/python2.5/unittest.py", line 794, in parseArgs
  File "/usr/lib/python2.5/unittest.py", line 800, in createTests
  File "/usr/lib/python2.5/unittest.py", line 565, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/lib/python2.5/unittest.py", line 553, in loadTestsFromName
    test = obj()
  File "./trac/test.py", line 568, in suite
    import tracopt.versioncontrol.git.tests
  File "/run/shm/8b3589370d1aa5b8d1bc82995d843ce2c2d1d789/py25-sqlite/tracopt/versioncontrol/git/tests/__init__.py", line 16, in <module>
    from tracopt.versioncontrol.git.tests import PyGIT, git_fs
  File "/run/shm/8b3589370d1aa5b8d1bc82995d843ce2c2d1d789/py25-sqlite/tracopt/versioncontrol/git/tests/PyGIT.py", line 33, in <module>
    from tracopt.versioncontrol.git.tests.git_fs import GitCommandMixin
  File "/run/shm/8b3589370d1aa5b8d1bc82995d843ce2c2d1d789/py25-sqlite/tracopt/versioncontrol/git/tests/git_fs.py", line 686
    with open(self.projects_list, 'w') as f:
SyntaxError: invalid syntax

comment:3 by Ryan J Ollos, 5 years ago

Resolution: fixed
Status: assignedclosed

Thanks for testing. I added the compatibility statement and committed to 1.0-stable in r14864, merged to trunk in r14865.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.