Changeset legend should appear before list of files

[anonymous]

When viewing a changeset, the legend that tells the user what colour squares mean what should appear at the top of the list, not the bottom. This, because if the user doesn't know what the colours mean, means s/he has to scroll to the bottom to find out, then back to the top (or where-ever s/he was looking).

This is only an issue where the changeset is large enough to cause the page to need a scrollbar, of course.

[Matthew Good <matt-good.net>]

Ok, it took me a second to realize what "list" they were referring to here, since the legend does appear before the list of the actual diffs. However, I believe they're meaning the list of filenames, so yes I can see the benefit of this.

[Christopher Lenz]

The legend is intentionally between the list of file names and the diffs because it applies to both. That doesn't make the design decision right though, so I'm leaving this open for ruther comments.

[sid]

Only the Added and Removed boxes seem to be applicable to both files and diffs.

All the other actions (unmodified, modified, copied, moved) apply only at the file level, right?

[Christian Boos]

The modified color is also meaningful for 'side by side diffs.

I plan to add one more color (*) for a merged type (see #3236) at the file level, so it's probably a good idea to split the current legend in two: file type legend before the list of files, diff legend before the diffs, the latter adapted to the current diff mode.

(*) suggestions welcomed for the color itself!

[anonymous]

I like splitting into 2. Maybe make the Modified color a little more yellow, and then the merge can be orange?

[Christian Boos]

Done in r4668.