Tickets totally broken in r5693

[dna]

1. When creating a new ticket it is counted and linked as closed in the roadmap view
2. The "Active Ticket" query also don't find it
3. The "Action" form fieldset of the ticket is empty

[Christian Boos]

Well, it works fine for me… any reason the action form fieldset might be empty for you?

e.g. what is your [ticket] workflow setting and if you're using the ConfigurableTicketWorkflow, what's your [ticket-workflow] section in trac.ini?

Ah, one possible (and likely) reason is the renaming of the DefaultTicketActionController to ConfigurableTicketWorkflow …

[dna]

Hello,

my trac.ini for [ticket]

[ticket]
default_component = General
default_milestone = Milestone 1
default_priority = major
default_type = defect
default_version =
max_description_size = 262144
restrict_owner = true
workflow = DefaultTicketActionController

[Christian Boos]

Yes, so you'll have now to use 'ConfigurableTicketWorkflow' instead of 'DefaultTicketActionController'.

Sorry for the inconvenience, but we felt that the new name was more expressive.

We should probably issue a warning if there's no action provider at all.

[dna]

Well,

this works for a new ticket. Any idea how to get the others to a "active" state?

Btw, such a warning or a ini-upgrader would be nice to have.

[Eli Carter]

Replying to dna:

Well,

this works for a new ticket. Any idea how to get the others to a "active" state?

There's a status fixer plugin in the sample-plugins/workflow directory. Until we have core setup to assist in this case, that's the way to fix those.

Btw, such a warning or a ini-upgrader would be nice to have.

Yeah, a warning would be good.

[sid]

Please don't change milestones as anonymous and without a reason.

[Tim Hatch]

Undo recent anonymous changes

[Christian Boos]

Revert another anonymous change… (TicketButcher playing here)

We could add a warning:

trac/ticket/api.py

@@ -149 +149 @@
         [TracTickets#Assign-toasDrop-DownList Assign-to as Drop-Down List]
         (''since 0.9'').""")
 
+    def __init__(self):
+        ctrlr_names = [c.__class__.__name__ for c in self.action_controllers]
+        self.log.debug('ticket action controllers: %r' % (ctrlr_names,))
+        default = 'ConfigurableTicketWorkflow'
+        if default not in ctrlr_names:
+            self.log.warning("default action controller '%s' not used", default)
+
     # Public API
 
     def get_available_actions(self, req, ticket):
         """Returns a sorted list of available actions"""
         # The list should not have duplicates.
         actions = {}
-        self.log.debug('action controllers: %s' % (self.action_controllers,))
         for controller in self.action_controllers:
             weighted_actions = controller.get_ticket_actions(req, ticket)
             for weight, action in weighted_actions:

[Christian Boos]

Ok, the warning in the above patch was deemed to be too obnoxious for people using a non-default workflow on purpose. So I just kept the cleanup of the log.debug, and added the 'workflow' keyword so that people having the same kind of trouble with the workflow than the one reported in this ticket will be able to find this information more easily, see r6823.