Edgewall Software
Modify

Opened 12 years ago

Closed 9 years ago

#5230 closed defect (wontfix)

Improved Trac post commit hook for subversion with bash completion

Reported by: nslater@… Owned by: Christian Boos
Priority: normal Milestone:
Component: version control Version:
Severity: normal Keywords: trac-post-commit-hook consider
Cc: Branch:
Release Notes:
API Changes:

Description

The Trac post commit hook in the contrib directory could be improved.

I have attached a reworked version of the script it calls along with

  • A bash completion script so that the script may be called interactively by the user.
  • A DocBook file that provides the man/info page for the command.

Attachments (0)

Change History (7)

comment:1 by anonymous, 12 years ago

I am unable to add attachments to the ticket because of a database error.

comment:2 by anonymous, 12 years ago

Attachments live here:

http://www.cs.rpi.edu/~kantrn/trac/5230/

P.S. Thanks coderanger.

comment:3 by sid, 12 years ago

Thanks for the files.

Generally (e.g. see #5402), updates to the commit hook scripts are not integrated since the scripts are provided as an example of better integration of Trac and SVN, and are expected to be customized to fit a team needs.

However, this might be worth applying to the default commit hook script. Any feedback from developers?

comment:4 by Christian Boos, 12 years ago

Component: generalversion control
Keywords: trac-post-commit-hook consider added
Milestone: 1.0
Owner: changed from Jonas Borgström to Christian Boos

Well, this looks like a total rewrite. I think given that we ask people to take the script and customize it to their needs, we should only take in small incremental improvements or bug fixes. Doing things that way is especially important when there's a need to propagate a bug fix (e.g. r5309).

So it would be wontfix from my side, at least for now. We may re-evaluate that later when integrating further improvements to the hooks, like #6135, #4746 etc.

in reply to:  4 comment:5 by Emmanuel Blot, 12 years ago

Replying to cboos:

So it would be wontfix from my side, at least for now. We may re-evaluate that later when integrating further improvements to the hooks, like #6135, #4746 etc.

-1 as well.

I'll rather see these various scripts either be stored on trac-hacks.org or attached to a dedicated page on trac.edgewall.org. Hook scripts are really specific to the way the Trac+SVN pair is used in a project.

One or more examples could be provided the same way as sample-worflows are with 0.11.

BTW, is there a DocBook-to-TracWiki converter available? It could be nice to document the sample script as a Wiki page and promote the work nslater has done.

comment:6 by Christian Boos, 9 years ago

Milestone: 1.0unscheduled

Milestone 1.0 deleted

comment:7 by Remy Blank, 9 years ago

Milestone: triaging
Resolution: wontfix
Status: newclosed

The trac-post-commit-hook has been replaced by the CommitTicketUpdater component in 0.12.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.