Edgewall Software
Modify

Opened 17 years ago

Closed 17 years ago

#5402 closed enhancement (wontfix)

allow : in the trac post-commit svn hook

Reported by: anarcat Owned by: Emmanuel Blot
Priority: low Milestone:
Component: general Version: 0.10.3
Severity: trivial Keywords:
Cc: anarcat@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

We changed a bit the regex for the trac hook here to allow "Closes: #000" syntax, as it is natural to some of us.

Here is the diff on the trunk hook:

--- trac-post-commit-hook.1     2007-05-31 18:27:40.000000000 -0400
+++ trac-post-commit-hook       2007-05-31 18:27:50.000000000 -0400
@@ -112,7 +112,7 @@

 ticket_prefix = '(?:#|(?:ticket|issue|bug)[: ]?)'
 ticket_reference = ticket_prefix + '[0-9]+'
-ticket_command =  (r'(?P<action>[A-Za-z]*).?'
+ticket_command =  (r'(?P<action>[A-Za-z]*):?.?'
                    '(?P<ticket>%s(?:(?:[, &]*|[ ]?and[ ]?)%s)*)' %
                    (ticket_reference, ticket_reference))

Trivial, really. :)

Attachments (0)

Change History (1)

comment:1 by Emmanuel Blot, 17 years ago

Component: notificationgeneral
Resolution: wontfix
Status: newclosed

Thanks for the patch.

However, commit hook scripts are provided as an example of better integration of Trac and SVN, and are expected to be customized to fit a team needs.

I'm closing this ticket as I don't think it is worth applying it to the default commit hook script, however it's still searchable for other users that look for hook script modifications and might find it useful.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Emmanuel Blot.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Emmanuel Blot to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.