Edgewall Software
Modify

Opened 12 years ago

Last modified 2 years ago

#6135 new enhancement

Enhancement for trac-post-commit-hook.py for Enterprise Workflow

Reported by: vinogradniy@… Owned by:
Priority: normal Milestone: unscheduled
Component: general Version:
Severity: normal Keywords: enterprise workflow, postcommit hook, CommitTicketUpdater
Cc: shansen@… Branch:
Release Notes:
API Changes:

Description

Enhancement for trac-post-commit-hook.py for Trac Enterprice Workflow.

Attachments (2)

trac-post-commit-hook_for-enterprice-workflow.py (8.6 KB ) - added by vinogradniy@… 12 years ago.
Enhancement for Enterprise Workflow
workflow-post-commit-hook.patch (11.2 KB ) - added by shansen@… 12 years ago.
workflow-aware version of trac-post-commit-hook

Download all attachments as: .zip

Change History (17)

by vinogradniy@…, 12 years ago

Enhancement for Enterprise Workflow

comment:1 by anonymous, 12 years ago

Priority: normalhigh
Summary: Enhancement for trac-post-commit-hook.py for Enterprice WorkflowEnhancement for trac-post-commit-hook.py for Enterprise Workflow

comment:2 by sid, 12 years ago

It would be useful (and greatly increase your chances of this getting merged) if this was presented as a diff file so we can see the code changes, and also if you can explain what the changes are and how they are helpful.

comment:3 by Christian Boos, 12 years ago

Milestone: 0.110.11.1

Maybe for 0.11.1.

comment:4 by shansen@…, 12 years ago

I wonder at the utility of this change, as I re-convert back to the trac world and blink in surprise at the old script I threw together seems to have been maintained all this time. That rocks, lol. :)

Anyways: as I fiddle and configure up our "enterprise workflow", what leaps out at me is that the change to the hook provided here makes two assumptions that seem dramatically wrong for me… and I wonder if they're wrong for others.

In my "Enterprise" setup, developers never close tickets. The most a developer does is claim to have fixed it, and send it to the QA bucket where it is then verified by someone else who has the right to close the ticket.

Secondly, the QA department never commits to the repository.

I'm thinking of working up a configurable hook that can suit either the OP's need or my own, whereby a commit message that claims to 'fix' a ticket actually just transfers it to QA. Must dig further into the internals first. :)

comment:5 by anonymous, 12 years ago

Cc: shansen@… added

by shansen@…, 12 years ago

workflow-aware version of trac-post-commit-hook

comment:6 by shansen@…, 12 years ago

Since the workflow-enabling was easier then I thought, I attached a patch for a suggested alternate implementation then the one originally suggested in the ticket. Should be tweakable to be compatible to my original hook, and configurable to do what the original poster wanted (a 'test' / 'verify' command), in addition to my own needs. I think! Works for me at least :)

comment:7 by matt@…, 11 years ago

How would I implement this into my trac install?

comment:8 by rock@…, 11 years ago

I had to add self.args = {} to DummyRequest's __init__ method in order for all actions to work properly.

comment:9 by anonymous, 11 years ago

Testing

comment:10 by Christian Boos, 11 years ago

Milestone: 0.11-retriage0.12

The post-commit-hook will have to be redesigned anyway on top of the IChangesetListener interface brought by #7723.

comment:11 by Christian Boos, 10 years ago

Keywords: enterprise workflow postcommit added; Enterprice Workflow post commit removed
Milestone: 0.120.13

This will have to updated w.r.t. the new CommitTicketUpdatePlugin (see r8094).

comment:12 by Christian Boos, 10 years ago

Keywords: CommitTicketUpdate added

s/to/to be/

comment:13 by Christian Boos, 9 years ago

Milestone: next-major-0.1Xunscheduled
Priority: highnormal

comment:14 by Ryan J Ollos, 4 years ago

Owner: Jonas Borgström removed

comment:15 by Ryan J Ollos, 2 years ago

Keywords: CommitTicketUpdater added; CommitTicketUpdate removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned. Next status will be 'new'.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.