Enhancement for trac-post-commit-hook.py for Enterprise Workflow

[vinogradniy@…]

Enhancement for trac-post-commit-hook.py for Trac Enterprice Workflow.

[vinogradniy@…]

Enhancement for Enterprise Workflow

[sid]

It would be useful (and greatly increase your chances of this getting merged) if this was presented as a diff file so we can see the code changes, and also if you can explain what the changes are and how they are helpful.

[Christian Boos]

Maybe for 0.11.1.

[shansen@…]

I wonder at the utility of this change, as I re-convert back to the trac world and blink in surprise at the old script I threw together seems to have been maintained all this time. That rocks, lol. :)

Anyways: as I fiddle and configure up our "enterprise workflow", what leaps out at me is that the change to the hook provided here makes two assumptions that seem dramatically wrong for me… and I wonder if they're wrong for others.

In my "Enterprise" setup, developers never close tickets. The most a developer does is claim to have fixed it, and send it to the QA bucket where it is then verified by someone else who has the right to close the ticket.

Secondly, the QA department never commits to the repository.

I'm thinking of working up a configurable hook that can suit either the OP's need or my own, whereby a commit message that claims to 'fix' a ticket actually just transfers it to QA. Must dig further into the internals first. :)

[shansen@…]

workflow-aware version of trac-post-commit-hook

[shansen@…]

Since the workflow-enabling was easier then I thought, I attached a patch for a suggested alternate implementation then the one originally suggested in the ticket. Should be tweakable to be compatible to my original hook, and configurable to do what the original poster wanted (a 'test' / 'verify' command), in addition to my own needs. I think! Works for me at least :)

[matt@…]

How would I implement this into my trac install?

[rock@…]

I had to add self.args = {} to DummyRequest's __init__ method in order for all actions to work properly.

[anonymous]

Testing

[Christian Boos]

The post-commit-hook will have to be redesigned anyway on top of the IChangesetListener interface brought by #7723.

[Christian Boos]

This will have to updated w.r.t. the new CommitTicketUpdatePlugin (see r8094).

[Christian Boos]

s/to/to be/