Ticket History Issues

[Tim Hatch <trac@…>]

Apologies in advance for this megaticket. I thought it might be good to have them all in one place since they're all related to the solution for #2945. Issues exist as of r4391.

• timeline/ticket_history.html:
  • $item.ipnr is always empty for me.
• timeline/ticket_view.html:
  • attachments don't show up when explicitly viewing current version (by design? what if I want an old attachment, are they still around?)
  • viewing explicit version always uses newest's description
• timeline/ticket_diff.html:
  • Doesn't include diff.js so the unified-vs-tabular links aren't there

[Christian Boos]

Replying to Tim Hatch <trac@timhatch.com>:

Apologies in advance for this megaticket.

No problem, this kind of check pointing is well appreciated.

I thought it might be good to have them all in one place since they're all related to the solution for #2945. Issues exist as of r4391.

Well, not really, some have always been there. Let's go through.

• timeline/ticket_history.html:
  • $item.ipnr is always empty for me.

ipnr was never recorded for the ticket subsystem, see #1890 and the TracDev/Proposals/Journaling.

• timeline/ticket_view.html:
  • attachments don't show up when explicitly viewing current version (by design? what if I want an old attachment, are they still around?)

Attachment history is currently parallel to normal ticket history, and also a bit "volatile": when an attachment is deleted or replaced the old attachment is deleted/replaced and the original attachment event simply disappears. Whether this is a good thing or not can be discussed, of course, as well as what would be a better approach, but this behavior was there since the beginning.

A short term "fix" would be to nevertheless display the attachments when we can do so, in viewing a specific ticket version (currently those events are simply skipped, because I felt they're not really part of the history because of the limitations described above).

• viewing explicit version always uses newest's description

That's defective, yes.

• timeline/ticket_diff.html:
  • Doesn't include diff.js so the unified-vs-tabular links aren't there

Ok, that's another defect.

[Christian Boos]

Main issue fixed in r4401.

From #4326, I gather that you're working on the diff.js issue, so I'll leave the issue open.

[Tim Hatch <trac@…>]

Here's the fix:

trac/ticket/web_ui.py

@@ -35 +35 @@
 from trac.util.text import CRLF, shorten_line
 from trac.versioncontrol.diff import get_diff_options, diff_blocks
 from trac.web import IRequestHandler
-from trac.web.chrome import add_link, add_stylesheet, INavigationContributor, \
-                            Chrome
+from trac.web.chrome import add_link, add_script, add_stylesheet, \
+                            INavigationContributor, Chrome
 
 
 class InvalidTicket(TracError):
@@ -411 +411 @@
                      'Version %d' % next_version)
 
         add_stylesheet(req, 'common/css/diff.css')
+        add_script(req, 'common/js/diff.js')
 
         data.update({
             'title': 'Ticket Diff',

[Christian Boos]

Ok, applied in r4403.

OTOH, I wonder if the unified diff view is really useful in these situations… So I did it for the sake of consistency, but I wouldn't have a problem if that was later reverted ;)

[Christopher Lenz]

Replying to cboos:

Replying to Tim Hatch <trac@timhatch.com>:

• timeline/ticket_history.html:
  • $item.ipnr is always empty for me.

ipnr was never recorded for the ticket subsystem, see #1890 and the TracDev/Proposals/Journaling.

So then, why is the template trying to display the IP address? That should be removed until it's actually backed by functionality, in the meantime all it does is cause confusion.

[Christian Boos]

Well, I removed it from the display in r4406, but I kept it in the template, as I'd like to ultimately converge to some generic _history or _diff templates.

There are currently only a few differences:

• diff:trunk/templates/wiki_diff.html//trunk/templates/ticket_diff.html
• diff:trunk/templates/wiki_history.html//trunk/templates/ticket_history.html

It would be better to have a common template and then be able to "inject" some additional elements to differentiate them where needed (e.g. add the delete version form in wiki diff).