Edgewall Software
Modify

Opened 18 years ago

Closed 18 years ago

#4326 closed defect (fixed)

diff.js chops off version number

Reported by: Tim Hatch <trac@…> Owned by: Christian Boos
Priority: normal Milestone: 0.11
Component: general Version: devel
Severity: trivial Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

source:trunk/htdocs/js/diff.js@4282#L10 does a substr(5) call on the titles, and I don't know why. In trunk, these titles look like "Revision 1", so chopping off the first few characters results in something like this being produced:

--- ion 3
+++ ion 18

In trying to come up with patches to fix #4322, it gets more complicated because the title when used in a ticket could be "Initial Version".

cmlenz, is there a reason for the substr call, rather than taking the whole title?

Attachments (0)

Change History (2)

comment:1 by Christian Boos, 18 years ago

Milestone: 0.11
Owner: changed from Christopher Lenz to Christian Boos
Severity: normaltrivial
Status: newassigned

is there a reason for the substr call, rather than taking the whole title?

I assume there was one, but as +++ Revision looks better than +++ ion, I'm going to fix this little glitch ;)

comment:2 by Christian Boos, 18 years ago

Resolution: fixed
Status: assignedclosed

Fixed in r4674.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.