External link in IE6 win is not rendered correctly (patch)

[diroussel]

I guess this is related to ticket:937

On Win IE6 external links are rendered in such a way that they are not properly recognised as links. The mouse cursor does not turn into the pointy finger, instead it stays as the vertical bar. Also right clicking on the link doesn't show "open link in new window". It's as if IE thinks it normal text, but if you do click the link then it open ok.

If found that if you change the HTML from

broken stlye link

<a class="ext-link" href="http://trac.edgewall.org"><span class="icon">broken stlye link</span></a>

to

magic new link

<a class="ext-link" href="http://trac.edgewall.org"><span class="icon"></span>magic new link</a>

then it fixes the problem. How does that look to you?

Sorry I've only got IE6 here, so I can't test on IE7, FF, KHTML etc.

[Christian Boos]

The contextual menu works as expected in iexplorer7.

However, it's worth noting that the "magic new link" proposed above doesn't display correctly in the same iexplorer7 ;-)

[anonymous]

Still fails in IE6.

[Christian Boos]

Well, it works when you're using IE7.

wontfix then. We're not going to spend much time supporting all the obsolete browsers out there (e.g. Netscape 4 on Solaris even segfaults with Trac ;-) ).

[salmira]

The same fail for browsers Maxthon 1.x and 2.x (based on IE6). It is easy to fix'''

Fix works for me:

Step 1) change lines in formatter.py lines trunk/trac/wiki/formatter.py@6010#L390​ and trunk/trac/wiki/formatter.py@6010#L396​ from

return html.A(html.SPAN(text, class_="icon"),

to

return html.A(text,

Step 2) add (or change) style in trunk/trac/htdocs/css/trac.css@6010#L54​

 a.ext-link {
  background: url(../extlink.gif) left center no-repeat;
  padding-left: 16px;
 }
 * html a.ext-link { display: inline-block; }
 
 a.mail-link {
  background: url(../envelope.png) left center no-repeat;
  padding-left: 16px;
 }
 * html a.mail-link { display: inline-block; }

I just cannot add this to SVN…

[Christian Boos]

Replying to salmira:

…

I just cannot add this to SVN…

Well, first step would be to learn how to submit patches so that you can share your changes with others without causing them headaches ;-)

[Emmanuel Blot]

Replying to cboos:

Replying to salmira: Well, first step would be to learn how to submit patches so that you can share your changes with others without causing them headaches ;-)

… pus, please do not change the summary of an existing ticket when adding a patch.

[techtonik <techtonik@…>]

BTW, the second style - a.mail-link .icon - is wrong ​http://trac.edgewall.org/browser/trunk/trac/htdocs/css/trac.css#L60 - there is no envelope.png image

[Emmanuel Blot]

Replying to techtonik <techtonik@php.net>:

BTW, the second style - a.mail-link .icon - is wrong ​http://trac.edgewall.org/browser/trunk/trac/htdocs/css/trac.css#L60 - there is no envelope.png image

​http://trac.edgewall.org/browser/trunk/trac/htdocs/envelope.png ?

[Christian Boos]

Contributors, please:

• don't reopen this ticket without proposing a patch
• that patch must have been successfully tested with at least all the major browsers (Firefox, Opera, IE7)

[techtonik <techtonik@…>]

Ok. I was looking at ​http://www.edgewall.org/chrome/common/envelope.png and this change just isn't here yet.

[techtonik <techtonik@…>]

the same patch in colour

[techtonik <techtonik@…>]

About the patch above.

There is no need to set display: inline-block; on span elements as left/right padding works with left inline stuff as well. IE6 digestive system doesn't like display: inline-block

​http://www.quirksmode.org/css/display.html#inlineblock

[Christian Boos]

See how things are easier with a tested patch? :-)

The fix doesn't disturb IE7 and I take your word that it works for IE6 as well. Committed in r6020.

[Emmanuel Blot]

Replying to techtonik <techtonik@gmail.com>:

Ok. I was looking at ​http://www.edgewall.org/chrome/common/envelope.png and this change just isn't here yet.

​http://trac.edgewall.org runs 0.10.4 and the changes you're referring to have been made for 0.11.