Edgewall Software
Modify

Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#4029 closed defect (fixed)

External link in IE6 win is not rendered correctly (patch)

Reported by: diroussel Owned by: Jonas Borgström
Priority: low Milestone: 0.11
Component: wiki system Version: 0.10.4
Severity: trivial Keywords: iexplorer css
Cc: Branch:
Release Notes:
API Changes:

Description

I guess this is related to ticket:937

On Win IE6 external links are rendered in such a way that they are not properly recognised as links. The mouse cursor does not turn into the pointy finger, instead it stays as the vertical bar. Also right clicking on the link doesn't show "open link in new window". It's as if IE thinks it normal text, but if you do click the link then it open ok.

If found that if you change the HTML from

broken stlye link
<a class="ext-link" href="http://trac.edgewall.org"><span class="icon">broken stlye link</span></a>

to

magic new link
<a class="ext-link" href="http://trac.edgewall.org"><span class="icon"></span>magic new link</a>

then it fixes the problem. How does that look to you?

Sorry I've only got IE6 here, so I can't test on IE7, FF, KHTML etc.

Attachments (2)

bug#4029.patch.txt (484 bytes ) - added by techtonik <techtonik@…> 12 years ago.
bug#4029trac.css.diff (532 bytes ) - added by techtonik <techtonik@…> 12 years ago.
the same patch in colour

Download all attachments as: .zip

Change History (15)

comment:1 by Christian Boos, 13 years ago

Resolution: worksforme
Status: newclosed

The contextual menu works as expected in iexplorer7.

However, it's worth noting that the "magic new link" proposed above doesn't display correctly in the same iexplorer7 ;-)

comment:2 by anonymous, 12 years ago

Resolution: worksforme
Status: closedreopened
Version: 0.100.10.4

Still fails in IE6.

comment:3 by Christian Boos, 12 years ago

Resolution: wontfix
Status: reopenedclosed

Well, it works when you're using IE7.

wontfix then. We're not going to spend much time supporting all the obsolete browsers out there (e.g. Netscape 4 on Solaris even segfaults with Trac ;-) ).

comment:4 by salmira, 12 years ago

Milestone: 0.11
Resolution: wontfix
Severity: normaltrivial
Status: closedreopened
Summary: External link in IE6 win is not rendered correctlyExternal link in IE6 win is not rendered correctly (patch)

The same fail for browsers Maxthon 1.x and 2.x (based on IE6). It is easy to fix'''

Fix works for me:

Step 1) change lines in formatter.py lines trunk/trac/wiki/formatter.py@6010#L390 and trunk/trac/wiki/formatter.py@6010#L396 from

return html.A(html.SPAN(text, class_="icon"),

to

return html.A(text,

Step 2) add (or change) style in trunk/trac/htdocs/css/trac.css@6010#L54

 a.ext-link {
  background: url(../extlink.gif) left center no-repeat;
  padding-left: 16px;
 }
 * html a.ext-link { display: inline-block; }
 
 a.mail-link {
  background: url(../envelope.png) left center no-repeat;
  padding-left: 16px;
 }
 * html a.mail-link { display: inline-block; }

I just cannot add this to SVN…

in reply to:  4 ; comment:5 by Christian Boos, 12 years ago

Replying to salmira:

I just cannot add this to SVN…

Well, first step would be to learn how to submit patches so that you can share your changes with others without causing them headaches ;-)

in reply to:  5 comment:6 by Emmanuel Blot, 12 years ago

Replying to cboos:

Replying to salmira: Well, first step would be to learn how to submit patches so that you can share your changes with others without causing them headaches ;-)

… pus, please do not change the summary of an existing ticket when adding a patch.

comment:7 by techtonik <techtonik@…>, 12 years ago

BTW, the second style - a.mail-link .icon - is wrong http://trac.edgewall.org/browser/trunk/trac/htdocs/css/trac.css#L60 - there is no envelope.png image

in reply to:  7 comment:8 by Emmanuel Blot, 12 years ago

comment:9 by Christian Boos, 12 years ago

Milestone: 0.11
Resolution: wontfix
Status: reopenedclosed

Contributors, please:

  • don't reopen this ticket without proposing a patch
  • that patch must have been successfully tested with at least all the major browsers (Firefox, Opera, IE7)

comment:10 by techtonik <techtonik@…>, 12 years ago

Ok. I was looking at http://www.edgewall.org/chrome/common/envelope.png and this change just isn't here yet.

by techtonik <techtonik@…>, 12 years ago

Attachment: bug#4029.patch.txt added

by techtonik <techtonik@…>, 12 years ago

Attachment: bug#4029trac.css.diff added

the same patch in colour

comment:11 by techtonik <techtonik@…>, 12 years ago

Resolution: wontfix
Status: closedreopened

About the patch above.

There is no need to set display: inline-block; on span elements as left/right padding works with left inline stuff as well. IE6 digestive system doesn't like display: inline-block

http://www.quirksmode.org/css/display.html#inlineblock

comment:12 by Christian Boos, 12 years ago

Keywords: iexplorer css added
Milestone: 0.11
Resolution: fixed
Status: reopenedclosed

See how things are easier with a tested patch? :-)

The fix doesn't disturb IE7 and I take your word that it works for IE6 as well. Committed in r6020.

in reply to:  10 comment:13 by Emmanuel Blot, 12 years ago

Replying to techtonik <techtonik@gmail.com>:

Ok. I was looking at http://www.edgewall.org/chrome/common/envelope.png and this change just isn't here yet.

http://trac.edgewall.org runs 0.10.4 and the changes you're referring to have been made for 0.11.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Jonas Borgström to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.