Opened 18 years ago
Closed 18 years ago
#3963 closed defect (fixed)
Links to tickets' comments are incorrectly escaped
Reported by: | Owned by: | Christian Boos | |
---|---|---|---|
Priority: | normal | Milestone: | 0.11 |
Component: | wiki system | Version: | 0.10 |
Severity: | minor | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
I want to link to a ticket's comment from outside of this ticket, ie, another ticket, a wiki page or a commit message.
Take ticket:3945#comment:2
for example. The "hash" and the "colon" are HTML-escaped, so even thou the correct link is displayed (albeit in the "broken link" color: ticket:3945#comment:2), the link itself does not work (goes to http://trac.edgewall.org/ticket/3945%23comment%3A2)
Attachments (0)
Change History (3)
follow-up: 2 comment:1 by , 18 years ago
Milestone: | → 0.11 |
---|---|
Owner: | changed from | to
Severity: | normal → minor |
comment:2 by , 18 years ago
I catch myself from time to time using this syntax as well. I'm also voting +1 for the more intuitive syntax ticket:42#comment:2
(above all this would also be consistent with the corresponding permalink url).
Replying to cboos:
0.11 already supports the following improved syntax, comment:6:ticket:2168, which is a bit better
Thanks, Christian. I wasn't aware of this syntax yet. :-)
comment:3 by , 18 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
This syntax is now supported (r4364).
Yeah, and that's because what you wrote is not the currently supported syntax…
I agree that what you wrote would be an intuitive syntax and we should support it I think, see comment:ticket:2168:6. Btw, that previous link is written using the only supported syntax by Trac 0.10, and I know that it's not an intuitive one ;).
0.11 already supports the following improved syntax, comment:6:ticket:2168, which is a bit better, first which comment, then the context if needed (and same thing for the
attachment:
syntax: first what is attached, then the context if needed).