NameError: Variable "completed" is not defined

[carl]

How to Reproduce

While trying to edit a milestone i get the following error. This might be due to me running the debian 0.10 packages and then upgrading to the svn 0.11 one. On the other hand the upgrade tools sais that the project is up to date.

System Information

Python	2.4.4c0 (#1, Jul 30 2006, 15:39:57) [GCC 4.1.2 20060715 (prerelease) (Debian 4.1.1-9)]
SQLite	3.3.8
pysqlite	2.3.2

Python Traceback

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 377, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 248, in dispatch
    content_type, data)
  File "/usr/lib/python2.4/site-packages/trac/web/chrome.py", line 483, in render_response
    return stream.render(method, doctype=doctype)
  File "/usr/lib/python2.4/site-packages/genshi/core.py", line 146, in render
    output = u''.join(list(generator))
  File "/usr/lib/python2.4/site-packages/genshi/output.py", line 200, in __call__
    for kind, data, pos in stream:
  File "/usr/lib/python2.4/site-packages/genshi/output.py", line 486, in __call__
    for kind, data, pos in chain(stream, [(None, None, None)]):
  File "/usr/lib/python2.4/site-packages/genshi/output.py", line 436, in __call__
    for kind, data, pos in stream:
  File "/usr/lib/python2.4/site-packages/genshi/core.py", line 207, in _ensure
    for event in stream:
  File "/usr/lib/python2.4/site-packages/genshi/filters.py", line 313, in __call__
    for kind, data, pos in stream:
  File "/usr/lib/python2.4/site-packages/genshi/template.py", line 1142, in _match
    content = list(content)
  File "/usr/lib/python2.4/site-packages/genshi/filters.py", line 313, in __call__
    for kind, data, pos in stream:
  File "/usr/lib/python2.4/site-packages/genshi/template.py", line 1117, in _match
    for event in stream:
  File "/usr/lib/python2.4/site-packages/genshi/template.py", line 1106, in _strip
    event = stream.next()
  File "/usr/lib/python2.4/site-packages/genshi/template.py", line 919, in _eval
    ctxt):
  File "/usr/lib/python2.4/site-packages/genshi/template.py", line 929, in _eval
    result = data.evaluate(ctxt)
  File "/usr/lib/python2.4/site-packages/genshi/eval.py", line 103, in evaluate
    {'data': data})
  File "/usr/share/trac/templates/milestone_edit.html", line 52, in <Expression u"format_date(milestone.completed) or format_date">
    <input type="text" id="completeddate" name="completeddate"
  File "/usr/lib/python2.4/site-packages/trac/web/chrome.py", line 424, in _format_date
    return format_date(tzinfo=req.tz, *args, **kw)
  File "/usr/lib/python2.4/site-packages/trac/util/datefmt.py", line 69, in format_date
    return format_datetime(t, format, tzinfo=tzinfo)
  File "/usr/lib/python2.4/site-packages/trac/util/datefmt.py", line 60, in format_datetime
    t = t.astimezone(tzinfo)
  File "/usr/lib/python2.4/site-packages/genshi/eval.py", line 150, in __getattr__
    self.throw()
  File "/usr/lib/python2.4/site-packages/genshi/eval.py", line 163, in throw
    raise NameError('Variable "%s" is not defined' % self._name)
NameError: Variable "completed" is not defined

[Christian Boos]

I checked in a quick fix in r3989, but that part of the code should be cleaned up a bit.