Edgewall Software
Modify

Opened 19 years ago

Closed 18 years ago

Last modified 11 years ago

#2168 closed enhancement (fixed)

Universal TracLinks argument

Reported by: Christian Boos Owned by: Christian Boos
Priority: normal Milestone: 0.11
Component: wiki system Version: devel
Severity: minor Keywords: traclinks
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Christian Boos)

Currently, each flavor of TracLinks implements its own "sub" syntax.

There is some consistency however, for example, a trailing "#fragment" is used to locate a specific anchor in the targeted objects. This works for section anchors in Wiki pages and more recently for line numbers in repository files.

Also, there's some support for the special "?format=raw" argument which works for attachment: links, and it was suggested that source: links adopt the same convention.

What becomes apparent from the above is that those conventions are pretty much the same as those used for URIs.

Therefore, I propose to add the query URI syntax to the TracLinks syntax, for the short and long form of links (but not for the shorthand forms).

Examples:

Attachments (0)

Change History (15)

comment:1 by Christian Boos, 19 years ago

See also #1209, for a similar request concerning milestone: links.

comment:2 by Christian Boos, 19 years ago

Milestone: 0.9.1

See also #2078, for a similar request concerning changeset: links.

comment:3 by Christopher Lenz, 19 years ago

Milestone: 0.9.10.9.2

comment:4 by Christopher Lenz, 19 years ago

Milestone: 0.9.31.0

comment:5 by Christian Boos, 19 years ago

See also #2635 for a discussion about uniform handling of versioning arguments (e.g. type:id@version for addressing a specific version of the object, and type:id@versionx:versiony for addressing a specific change or group of changes for the object).

comment:6 by Christian Boos, 19 years ago

Milestone: 1.00.11

We should also allow fragment identifiers after tickets (e.g. ticket:2168#comment:5 or #2168#comment:5) and changesets (e.g. r1231#file3, see #2078).

in reply to:  6 comment:7 by Christian Boos, 18 years ago

Replying to cboos:

We should also allow fragment identifiers after tickets (e.g. ticket:2168#comment:5 or #2168#comment:5) …

How funny, I just wanted to write a comment here saying just that… again!

I find the current comment link syntax (e.g. comment:ticket:3555:5) a bit irritating… It was initially modelled after the attachment syntax (e.g. attachment:<resource>:<file>), but in the case of comments, it's really annoying to have to split the comment: prefix and the comment number.

Maybe we could change both syntaxes to thing:which_thing:type:id? Ideally, this could even be "recursive", e.g. comment:4:attachment:the_file.txt:ticket:345.

Just brainstorming…

comment:8 by Christian Boos, 18 years ago

(side-note: the syntax changes suggested in comment:7 were implemented in [3824:3828])

comment:9 by Christian Boos, 18 years ago

r4364 added argument support for ticket: TracLinks, as well as support for the comment syntax suggested in comment:6.

comment:10 by Christian Boos, 18 years ago

Keywords: TracLinks added

r4367 added argument and fragment support for changeset: and diff: TracLinks.

comment:11 by Christian Boos, 18 years ago

Description: modified (diff)
Status: newassigned

r4368 added argument and fragment support for source: and log: TracLinks. export: TracLinks have only support for fragments, as the reason to have export: link was specifically to not have any arguments in URLs (see r4242).

comment:12 by Christian Boos, 18 years ago

Resolution: fixed
Status: assignedclosed

… and finally with r4371 and the milestone: TracLinks, the main purpose of this ticket is fulfilled. If there's any issue with the changes introduced (or omissions), please create new defect tickets.

In future iterations of the Wiki engine, more things could probably be done at the generic level, but until that time, the functionality as at least there.

comment:13 by Ryan J Ollos, 11 years ago

Keywords: traclinks added; TracLinks removed

comment:14 by Ryan J Ollos, 11 years ago

Keywords: traclink added; traclinks removed

comment:15 by Ryan J Ollos, 11 years ago

Keywords: traclinks added; traclink removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.