Edgewall Software
Modify

Opened 14 years ago

Closed 10 years ago

Last modified 8 years ago

#2635 closed enhancement (fixed)

wiki link to go to wiki differences

Reported by: Dave Matthews Owned by: Christian Boos
Priority: normal Milestone: 0.12
Component: wiki system Version: 0.9.3
Severity: normal Keywords:
Cc: daved@…, Christian Boos Branch:
Release Notes:
API Changes:

Description (last modified by Christian Boos)

Currently you can refer to particular versions of wiki pages using #, e.g. TracLinks#16 (although this is not documented in TracLinks and is inconsistent with the @ syntax now used for source links). However, I am not aware of any way to link to the changes made to a wiki page at a particular version. This would be useful to be able to refer to from tickets in the same way that we can already refer to source changesets.


Note: I think what's really important in this request is the ability to identify some particular change to a wiki page.

Therefore I think that being able to specify a given revision (using "@", not "#" as written above) is what really matters here.

Attachments (2)

t2635-Last-modified-link-r9091.patch (3.3 KB ) - added by Christian Boos 10 years ago.
Wiki view: revisit UI for link to last diff
diff-link-for-source-revision-r9093.diff (1.9 KB ) - added by Christian Boos 10 years ago.
Source browser: remove Last Change contextual navigation link and add a (diff) link in the revision information panel

Download all attachments as: .zip

Change History (27)

comment:1 by anonymous, 14 years ago

Type: defectenhancement

comment:2 by Matthew Good, 14 years ago

The example above of TracLinks#16 only puts an anchor on the URL, it doesn't link to that version.

comment:3 by Dave Matthews, 14 years ago

Yes, of course - sorry, don't know where I got that idea. In that case, the ability to link to particular versions of wiki pages could be useful as well.

comment:4 by Christian Boos, 14 years ago

Keywords: tracobject added
Owner: changed from Jonas Borgström to Christian Boos

Being able to link to a specific wiki version (e.g. WikiStart@13) would be a good idea.

But actually there would be two possible targets:

  • the object as it looked like at a specific version (e.g. WikiStart@13, the wiki page as it was at version 13, what you can see here
  • the actual difference from one version to the previous one (e.g. WikStart@13:12 from version 13 to version 12, what you can see here. For an alternative visualization proposal, see the discussion in #2165.

See also #2168 for a proposal for adding more uniform treatment to TracLinks.

As part of the TracObjectModelProposal, I think that every Trac Object could be seen as a versioned resource, and in this case, it should be possible to address that history in a consistent way (both for the version retrieval and the view of the change).

comment:5 by stevegt, 14 years ago

I'm going to need to implement the WikiStart@13 syntax to support http://trac-hacks.org/wiki/WikiWorkflowPatch — any preferences as to whether I include it in that patch, or as a separate standalone plugin?

(Note: restoring original comment content, which was modified by mistake - I edited the comment:4 actually but it was saved as a new version of comment:5 :-/ )

Last edited 10 years ago by Christian Boos (previous) (diff)

comment:6 by stevegt@…, 14 years ago

After poking at this for a while, I'm beginning to thing that WikiStart.13 might be a much better syntax; the application I'm working on will cause that string to be seen and typed a lot, often by less-technical folks. While I agree there's precedent for that '@' sign, it's ugly as heck… I'm tentatively planning to implement this as WikiStart.13 and WikiStart.13:14 instead; still not decided on patch or plugin.

comment:7 by anonymous, 14 years ago

s/thing/think/

comment:8 by anonymous, 13 years ago

Cc: daved@… added

comment:9 by Christian Boos, 13 years ago

Description: modified (diff)
Keywords: tracobject removed
Milestone: 0.11
Status: newassigned
Summary: Can't create wiki link to wiki differenceswiki link to go to wiki differences

Now with r4370, the syntax proposed in comment:4 is implemented.

With this and the ability to quickly go to the actual changes from the displayed version using the Last Change link, I don't think it's still worth to have an explicit TracLinks syntax for accessing the differences directly… this seems a bit overkill.

Now, what can eventually be adapted is what should we preferably show when clicking on a "WikiStart@2" link: that given version (as it is currently done in r4370) or the diffs from that version to the previous one? In either case, the other view is one click away…

So let me know if you prefer the alternative or if things are now OK like that.

(Sorry stevegt about the choice of "@" over ".": I favored consistency. Besides, this keeps open the possibility that one day we'll support digits and dots in WikiPageNames, i.e. #425)

comment:10 by Dave Matthews, 13 years ago

I think that the "@" syntax should refer to the specific version and not the changes to be consistent with how it is used in "source:" links.

Now that there is a Last Change link I agree that a further syntax to support direct links to the changes is probably overkill so I'm happy.

Thanks.

comment:11 by Christian Boos, 13 years ago

Resolution: fixed
Status: assignedclosed

Good, thanks for the confirmation.

comment:12 by matt_callaghan@…, 12 years ago

Cc: Christian Boos added
Resolution: fixed
Status: closedreopened

Interesting …

I'm not sure if this warrants a re-open, but we're running version 10.4 and this proposed syntax as mentioned in comment 4 doesn't seem to work.

Also, what about this Wiki pages that do NOT follow camel case (i.e. acronyms) and require the

[wiki:MYACRONYM]

syntax?

Would:

[wiki:MYACRONYM@##]

work?

Thanks in advance,

comment:13 by Christian Boos, 12 years ago

Resolution: fixed
Status: reopenedclosed

Sorry, this is only a 0.11 feature, as written in comment:9.

And yes, [wiki:MYACRONYM@##] will work as expected (even wiki:MYACRONYM@##, [wiki:MYACRONYM@## label] and ["MYACRONYM@##"], see WikiPageNames).

in reply to:  10 ; comment:14 by Christian Boos, 11 years ago

Resolution: fixed
Status: closedreopened

Replying to Dave Matthews:

I think that the "@" syntax should refer to the specific version and not the changes to be consistent with how it is used in "source:" links.

Now that there is a Last Change link I agree that a further syntax to support direct links to the changes is probably overkill so I'm happy.

There's a regression right now about this (no Last Change link in the Wiki version page), reopening this ticket as a reminder.

in reply to:  14 ; comment:15 by Christian Boos, 11 years ago

Resolution: fixed
Status: reopenedclosed

There's a regression right now about this (no Last Change link in the Wiki version page)

Fixed in r7028.

in reply to:  15 comment:16 by Christian Boos, 11 years ago

Resolution: fixed
Status: closedreopened

Replying to cboos:

There's a regression right now about this (no Last Change link in the Wiki version page)

Fixed in r7028.

I'm still not happy with this, will revert.

comment:17 by Christian Boos, 11 years ago

Milestone: 0.11.10.11
Resolution: fixed
Status: reopenedclosed

Well, perhaps not 100% happy, but the current status will do ;-)

in reply to:  17 ; comment:18 by Christian Boos, 10 years ago

Milestone: 0.110.12
Resolution: fixed
Status: closedreopened

Replying to cboos:

Well, perhaps not 100% happy, but the current status will do ;-)

Found something better ;-)

I'd like to get feedback on attachment:t2635-Last-modified-link-r9091.patch.

by Christian Boos, 10 years ago

Wiki view: revisit UI for link to last diff

in reply to:  18 ; comment:19 by Remy Blank, 10 years ago

Replying to cboos:

I'd like to get feedback on attachment:t2635-Last-modified-link-r9091.patch.

+1

It's important to keep a (diff) link at the top when viewing a specific versoin, as it allows viewing the diff for a wiki page edit in a single click from an RSS reader.

in reply to:  19 ; comment:20 by Christian Boos, 10 years ago

Resolution: fixed
Status: reopenedclosed

Replying to rblank:

Replying to cboos:

I'd like to get feedback on attachment:t2635-Last-modified-link-r9091.patch.

+1

Fine, committed as [9093].

It's important to keep a (diff) link at the top when viewing a specific version

I think we should also do that in the source browser, for consistency, what do you think?

in reply to:  20 ; comment:21 by Remy Blank, 10 years ago

Replying to cboos:

I think we should also do that in the source browser, for consistency, what do you think?

Do you mean also removing the "Last Change" in the ctxtnav and add a (diff) link next to the "Revision 1234, 346 bytes (checked in by cboos, 5 months ago)"? Yes, that could work quite well.

in reply to:  21 comment:22 by Christian Boos, 10 years ago

Replying to rblank:

Replying to cboos:

I think we should also do that in the source browser, for consistency, what do you think?

Do you mean also removing the "Last Change" in the ctxtnav and add a (diff) link next to the "Revision 1234, 346 bytes (checked in by cboos, 5 months ago)"? Yes, that could work quite well.

Yes, forgot to attach the change for review diff-link-for-source-revision-r9093.diff.

by Christian Boos, 10 years ago

Source browser: remove Last Change contextual navigation link and add a (diff) link in the revision information panel

comment:23 by Remy Blank, 10 years ago

Nice!

comment:24 by Ryan J Ollos <ryano@…>, 8 years ago

The ability to specify a specific wiki page revision using the syntax WikiStart@1 is still not mentioned on the TracLinks page, so I added a sentence, TracLinks@83#wiki:links. I wasn't sure whether to include a mention of this in TracLinks@83#Overview as well.

comment:25 by Christian Boos, 8 years ago

I think the overview is best kept relatively simple. Further details are present in each specialized sections or dedicated pages. The @n syntax was already mentioned in the WikiPageNames page, but it doesn't hurt to briefly mention it in the wiki:links section as you did.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.