retarget open tickets to other milestone of choice - Webadmin

[jl]

This would be the same functionality as #2743 for the main trac (r3372 & r3732). I prefer to work with the webadmin and I would like to see this feature also in the webadmin.

Closing a milestone manually should retarget open tickets to other milestone of choice. This should be very similar to deleting a milestone.

[sid]

This ticket is confusing. #2743 does exactly what this ticket wants except it does it in the Roadmap when you are closing a milestone.

Currently, there are no features to manipulate the roadmap or milestones using WebAdmin. Is that the feature requested in this ticket? Could this be accomplished using batch ticket modification instead (see #525)?

[Christopher Lenz]

Actually, the current WebAdmin plugin (and the integrated admin in trunk) does support milestone management. And indeed, the issue raised here is the only feature missing.

The reason it's not been implemented yet is that WebAdmin generally allows deleting multiple items at once, and I'm not sure how to integrate that with retargetting tickets at deletion time. But once this does get added, the traditional milestone management via the roadmap will probably be removed completely (because it'd be redundant.

[ThurnerRupert]

i am not sure if traditional milestone management is not more intuitive. you also do not manage wiki pages via web-admin, or attachment deletions.

[Christian Boos]

Replying to ThurnerRupert:

i am not sure if traditional milestone management is not more intuitive. you also do not manage wiki pages via web-admin, or attachment deletions.

I tend to agree, I don't think it makes sense to remove milestone management in the traditional milestone editor. Actually, it would be more interesting to simply be able to reuse that editor in the admin panel context, when editing one milestone.

However, when doing a deletion of several milestones at once, it should be possible to select a milestone to be the new milestone to associate to tickets that belonged to the milestones that are going to be deleted.

[Ryan J Ollos]

This was recently discussed on the ​mailing list, and I'll plan to implement following #5658 and #4582 with the following goals for the milestone admin page:

• Provide a select for retargeting on milestone deletion. One possibility is to have a confirm page, like you see when deleting a milestone from the Roadmap.
• Investigate reuse of milestone_edit.html in milestone admin. The Milestone edit page /milestone/milestone1?action=edit and Admin milestone edit page differ very slightly, with the latter only lacking the functionality to retarget tickets.

Milestone edit page

Admin Milestone edit page

[Ryan J Ollos]

Replying to rjollos:

• Investigate reuse of milestone_edit.html in milestone admin. The Milestone edit page /milestone/milestone1?action=edit and Admin milestone edit page differ very slightly, with the latter only lacking the functionality to retarget tickets.

This is also slightly related to #1233. In #1233, it is proposed to add Milestone-like pages for viewing and managing Components and Versions. If we can successfully include the same form within milestone_edit.html and admin_milestone_edit.html, then it should translate to the possibility of extracting the form from admin_component.html for reuse in component_edit.html, and likewise for the Versions edit pages.

[Ryan J Ollos]

Replying to rjollos:

If we can successfully include the same form within milestone_edit.html and admin_milestone_edit.html, then it should translate to the possibility of extracting the form from admin_component.html for reuse in component_edit.html, and likewise for the Versions edit pages.

These changes are pretty extensive, so I've made a new ticket #11499.

[Ryan J Ollos]

comment:73:ticket:5658 notes the need for a batch notification when deleting a milestone.

[anonymous]

When closing a milestone retarget tickets in same way as on roadmap:

trac/ticket/admin.py

@@ -18 +18 @@
 from trac.resource import ResourceNotFound
 from trac.ticket import model
 from trac.ticket.api import TicketSystem
-from trac.ticket.roadmap import MilestoneModule
+from trac.ticket.roadmap import MilestoneModule, \
+                                get_num_tickets_for_milestone, \
+                                group_milestones
 from trac.util import as_int, getuser
 from trac.util.datefmt import format_date, format_datetime, \
                               get_datetime_format_hint, parse_date, user_time
@@ -249 +251 @@
                 elif 'cancel' in req.args:
                     req.redirect(req.href.admin(cat, page))
 
+            milestones = [m for m in model.Milestone.select(self.env)
+                          if m.name != milestone.name
+                          and 'MILESTONE_VIEW' in req.perm(m.resource)]
+            milestone_groups = group_milestones(milestones, 
+                                                'TICKET_ADMIN' in req.perm)
+            num_open_tickets = \
+                get_num_tickets_for_milestone(self.env, milestone,
+                                              exclude_closed=True)
+
             chrome = Chrome(self.env)
             chrome.add_wiki_toolbars(req)
             chrome.add_auto_preview(req)
             data = {'view': 'detail',
                     'milestone': milestone,
-                    'default_due': milestone_module.get_default_due(req)}
+                    'default_due': milestone_module.get_default_due(req),
+                    'milestone_groups': milestone_groups,
+                    'num_open_tickets': num_open_tickets,
+                    'retarget_to': milestone_module.default_retarget_to}
 
         # List view
         else:

[anonymous]

Please can you let me know what is missing in the patch above for Trac? It would be very helpful. Thanks! 🎅

[Ryan J Ollos]

Replying to anonymous:

Please can you let me know what is missing in the patch above for Trac? It would be very helpful. Thanks! 🎅

I'll review soon. Thanks for the patch. It will need unit tests, per TracDev/SubmittingPatches.

[anonymous]

Thanks!

I found the existing unit tests for milestone admin in trac.ticket.tests.admin.MilestoneAdminPanelTestCase​, and functional tests in trac.ticket.tests.functional.admin.TestAdminMilestoneCompleted*​. They still succeed but don't test the retargeting feature yet.

Unit tests for the roadmap are in trac.ticket.tests.roadmap.MilestoneModuleTestCase​, but I could not find anything related to the retargeting feature there. Functional tests for the roadmap *do* test the retargeting feature in trac.ticket.tests.functional.main.TestMilestoneClose​.

Is it sufficient to copy that functional test to a new trac.ticket.tests.functional.admin.TestAdminMilestoneCompletedRetargeting, and adjusting it to use the admin panel instead of the roadmap? → I did that in T3754_milestone_retarget.patch​.

[Ryan J Ollos]

Milestone renamed

[Ryan J Ollos]

Replying to anonymous:

Is it sufficient to copy that functional test to a new trac.ticket.tests.functional.admin.TestAdminMilestoneCompletedRetargeting, and adjusting it to use the admin panel instead of the roadmap? → I did that in T3754_milestone_retarget.patch​.

Sorry for the delay. Looks good to me. I'll add some unit test coverage and commit the changes.

[anonymous]

Thanks! 🥮

[Ryan J Ollos]

Added some test coverage: [f99f91400/rjollos.git]

Nice that this was pretty simple to do after #11499 (comment:7). I hope to work on #1233 soon.

[anonymous]

Nice 🎀

[Ryan J Ollos]

Related changed in r17352 on 1.4-stable, merged in r17353.

Fixed in r17354.