Opened 4 years ago
Closed 23 months ago
#13402 closed task (fixed)
Release Trac 1.5.4
Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
---|---|---|---|
Priority: | normal | Milestone: | 1.5.4 |
Component: | general | Version: | |
Severity: | normal | Keywords: | release |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Released Trac 1.5.4. |
Description
This ticket is used to coordinate the finalization and testing of the next development-stable release of Trac, 1.5.4.
Attachments (0)
Change History (35)
comment:2 by , 3 years ago
Owner: | set to |
---|---|
Status: | new → assigned |
comment:3 by , 3 years ago
Replying to Ryan J Ollos:
$ make tx-merge-es ... TypeError: write() argument must be str, not bytes
Sorry for long delay. Fixed in [17570].
follow-up: 7 comment:4 by , 3 years ago
Considering the issue fixed in #13404 which came up again in gmessage:trac-users:JJA_WX-JH-4/SLVlDxK7EQAJ, aiming to make a new release this weekend.
comment:6 by , 3 years ago
There will be few additions scheduled for 1.6 which are not already in the development version 1.5.4. The key tickets to resolve are: #13332, #13358, #13406
See TracDownload#Tractrunk for installation guidance.
See also #13333#comment:15
follow-up: 8 comment:7 by , 3 years ago
Replying to Ryan J Ollos:
Considering the issue fixed in #13404 which came up again in gmessage:trac-users:JJA_WX-JH-4/SLVlDxK7EQAJ, aiming to make a new release this weekend.
@Ryan, I know you are time limited but I would like to know if there is a schedule/timeframe to push release 1.5.4 so I can re-plan accordingly. Thanks.
comment:8 by , 3 years ago
Replying to Bruce <bruce@…>:
@Ryan, I know you are time limited but I would like to know if there is a schedule/timeframe to push release 1.5.4 so I can re-plan accordingly. Thanks.
Very soon is my hope, but I cannot guarantee.
comment:9 by , 3 years ago
Hi,
any news? Slowly I start to loose hope it will happen some day. Still love Trac the most :-)
comment:10 by , 3 years ago
Aiming for a 1.5.4 release on Sunday 4/10. Jun, would you have time to commit your staged changes and pull the latest translations before then?
follow-up: 12 comment:11 by , 3 years ago
Started prepping for release. Looks like we have 2 more tickets to close for 1.4.4 and 1.5.4.
comment:12 by , 3 years ago
Replying to Ryan J Ollos:
Started prepping for release. Looks like we have 2 more tickets to close for 1.4.4 and 1.5.4.
So what does this mean in terms of the timeline to release 1.5.4?
comment:13 by , 3 years ago
I've been pretty limited for time lately. There are 3 open issues for milestone:1.4.4 and milestone:1.5.4. If anyone can contribute to those, that would be great. Otherwise I will boot them forward and push out 1.5.4 at least when I have a little time.
comment:14 by , 2 years ago
Hi,
when will 1.5.4 be released? Waiting for the jQuery update in 1.5.4 due to security issues. :-)
comment:15 by , 2 years ago
You can safely upgrade jQuery to the latest version as an intermediate step. Tested with Trac 1.5.2.
comment:16 by , 2 years ago
I think we should finally just kick the remaining issues forward and create the release. Jun, is there anything you want to include that could be done this week or next? Would you have time to update the translations?
follow-up: 19 comment:18 by , 2 years ago
I'm seeing a few test failures with Python 3.11 on macOS:
Python: /Users/rjollos/.pyenv/shims/python /Users/rjollos/.pyenv/versions/trac-3.11/lib/python3.11/site-packages/_distutils_hack/__init__.py:33: UserWarning: Setuptools is replacing distutils. warnings.warn("Setuptools is replacing distutils.") Package Version ---------------------------------------------------------------------------------------- Python : 3.11.1 (main, Dec 8 2022, 22:54:44) [Clang 14.0.0 (clang-1400.0.29.202)] Setuptools : 65.6.3 Pip : 22.3.1 Wheel : 0.38.4 Jinja2 : 3.1.2 Babel : 2.11.0 sqlite3 : 2.6.0 (3.39.5) PySqlite3 : not installed PyMySQL : 1.0.2 Psycopg2 : 2.9.5 (dt dec pq3 ext lo64) SVN bindings : not installed Mercurial : 6.3.1 Pygments : 2.13.0 Textile : 4.0.2 Pytz : 2022.7 Docutils : 0.19 Selenium : 4.7.2 PyTidyLib : 0.3.2 (5.8.0 /usr/local/lib/libtidy.dylib) LXML : 4.9.2 coverage : 7.0.1 Variables: PATH=/Users/rjollos/Documents/Workspace/trac-dev/bin:/Users/rjollos/Documents/Workspace/trac-dev/subversion-trunk/local/bin:/usr/local/Cellar/tidy-html5/5.6.0/bin:/Users/rjollos/.pyenv/shims:/usr/local/opt/sqlite/bin:/usr/local/opt/gnu-sed/libexec/gnubin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Applications/VMware Fusion.app/Contents/Public:/Library/TeX/texbin:/usr/local/munki:/opt/X11/bin:/Library/Apple/usr/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/Applications/Wireshark.app/Contents/MacOS:/Users/rjollos/.pyenv/bin PYTHONPATH=. TRAC_TEST_DB_URI= server-options= -p 8000 -a '*,/Users/rjollos/Documents/Workspace/trac-dev/tracenvs/htdigest.trac,trac' -r -e /Users/rjollos/Documents/Workspace/trac-dev/tracenvs External dependencies: Git version: git version 2.39.0 Subversion version: 1.15.0-dev
====================================================================== FAIL: test_i18n_datetime_hint (trac.util.tests.datefmt.I18nDateFormatTestCase.test_i18n_datetime_hint) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/util/tests/datefmt.py", line 1250, in test_i18n_datetime_hint self.assertIn(datefmt.get_datetime_format_hint(fr), AssertionError: 'd MMM y, HH:mm:ss' not found in ('d MMM yyyy HH:mm:ss', 'd MMM y HH:mm:ss', "d MMM y 'à' HH:mm:ss") ====================================================================== FAIL: test_i18n_format_datetime (trac.util.tests.datefmt.I18nDateFormatTestCase.test_i18n_format_datetime) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/util/tests/datefmt.py", line 1175, in test_i18n_format_datetime self.assertIn(datefmt.format_datetime(t, tzinfo=tz, locale=fr), AssertionError: '28 août 2010, 13:45:56' not found in ('28 août 2010 13:45:56', '28 août 2010 à 13:45:56') ====================================================================== FAIL: test_i18n_format_time (trac.util.tests.datefmt.I18nDateFormatTestCase.test_i18n_format_time) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/util/tests/datefmt.py", line 1233, in test_i18n_format_time self.assertIn(datefmt.format_time(t, tzinfo=tz, locale=zh_CN), AssertionError: '13:45:56' not found in ('下午01:45:56', '下午1:45:56') ====================================================================== FAIL: test_i18n_parse_date_datetime (trac.util.tests.datefmt.I18nDateFormatTestCase.test_i18n_parse_date_datetime) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/util/tests/datefmt.py", line 1367, in test_i18n_parse_date_datetime self.assertEqual(expected, AssertionError: datet[16 chars]0, 8, 28, 13, 45, 56, tzinfo=<FixedOffset "GMT +2:00" 2:00:00>) != datet[16 chars]0, 8, 28, 1, 45, 56, tzinfo=<FixedOffset "GMT +2:00" 2:00:00>) ====================================================================== FAIL: test_i18n_parse_date_datetime_meridiem (trac.util.tests.datefmt.I18nDateFormatTestCase.test_i18n_parse_date_datetime_meridiem) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/util/tests/datefmt.py", line 1398, in test_i18n_parse_date_datetime_meridiem self.assertEqual(expected_am, AssertionError: datet[16 chars]1, 2, 22, 0, 45, 56, tzinfo=<FixedOffset "GMT +2:00" 2:00:00>) != datet[16 chars]1, 2, 22, 12, 45, 56, tzinfo=<FixedOffset "GMT +2:00" 2:00:00>) ====================================================================== FAIL: test_i18n_parse_date_roundtrip (trac.util.tests.datefmt.I18nDateFormatTestCase.test_i18n_parse_date_roundtrip) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/util/tests/datefmt.py", line 1454, in test_i18n_parse_date_roundtrip self.assertEqual(tz_t, actual, AssertionError: datet[16 chars]0, 8, 28, 13, 45, 56, tzinfo=<FixedOffset "GMT +2:00" 2:00:00>) != datet[16 chars]0, 8, 28, 1, 45, 56, tzinfo=<FixedOffset "GMT +2:00" 2:00:00>) : datetime.datetime(2010, 8, 28, 13, 45, 56, tzinfo=<FixedOffset "GMT +2:00" 2:00:00>) != datetime.datetime(2010, 8, 28, 1, 45, 56, tzinfo=<FixedOffset "GMT +2:00" 2:00:00>) ('2010年8月28日 下午1:45:56' Locale('zh', territory='TW', script='Hant')) ---------------------------------------------------------------------- Ran 2562 tests in 65.945s FAILED (failures=6, skipped=6) make: *** [unit-test] Error 1
follow-up: 21 comment:19 by , 2 years ago
I'm seeing a few test failures with Python 3.11 on macOS:
FAILED (failures=6, skipped=6)
Yeah, that's has been reported at #13482 (not yet fixed). I'd like to pin with Babel<2.10
because I need more time to fix it.
follow-up: 23 comment:20 by , 2 years ago
I got 2 failures with Python 3.11 on Windows.
Python: /c/Users/runneradmin/AppData/Local/venv/Scripts/python Package Version ----------------------------------------------------------------------------------------------- Python : 3.11.1 (tags/v3.11.1:a7a450f, Dec 6 2022, 19:58:39) [MSC v.1934 64 bit (AMD64)] Setuptools : 65.6.3 Pip : 22.3.1 Wheel : not installed Jinja2 : 3.1.2 Babel : not installed sqlite3 : 2.6.0 (3.39.4) PySqlite3 : not installed PyMySQL : not installed Psycopg2 : not installed SVN bindings : not installed Mercurial : not installed Pygments : not installed Textile : not installed Pytz : not installed Docutils : not installed Selenium : 4.7.2 PyTidyLib : 0.3.2 (5.9.14 C:\Users\runneradmin\AppData\Local\venv\Scripts\tidy.dll) LXML : not installed coverage : not installed Variables: PATH=/mingw64/bin:/usr/bin:/c/Users/runneradmin/bin:/c/Users/runneradmin/AppData/Local/venv/Scripts:/c/Users/runneradmin/AppData/Local/venv/Scripts/Scripts:/c/Users/runneradmin/AppData/Local/venv/Scripts:/c/Program Files/PowerShell/7:/c/Users/runneradmin/AppData/Roaming/Python/Python311/Scripts:/c/hostedtoolcache/windows/Python/3.11.1/x64/Scripts:/c/hostedtoolcache/windows/Python/3.11.1/x64:/c/Program Files/MongoDB/Server/5.0/bin:/c/aliyun-cli:/c/vcpkg:/c/Program Files (x86)/NSIS:/c/tools/zstd:/c/Program Files/Mercurial:/c/hostedtoolcache/windows/stack/2.9.1/x64:/c/cabal/bin:/c/ghcup/bin:/c/tools/ghc-9.4.2/bin:/c/Program Files/dotnet:/c/mysql/bin:/c/Program Files/R/R-4.2.2/bin/x64:/c/SeleniumWebDrivers/GeckoDriver:/c/Program Files (x86)/sbt/bin:/c/Program Files (x86)/GitHub CLI:/bin:/c/Program Files (x86)/pipx_bin:/c/npm/prefix:/c/hostedtoolcache/windows/go/1.17.13/x64/bin:/c/hostedtoolcache/windows/Python/3.9.13/x64/Scripts:/c/hostedtoolcache/windows/Python/3.9.13/x64:/c/hostedtoolcache/windows/Ruby/3.0.5/x64/bin:/c/tools/kotlinc/bin:/c/hostedtoolcache/windows/Java_Temurin-Hotspot_jdk/8.0.352-8/x64/bin:/c/Program Files/ImageMagick-7.1.0-Q16-HDRI:/c/Program Files (x86)/Microsoft SDKs/Azure/CLI2/wbin:/c/ProgramData/kind:/c/Program Files/Microsoft/jdk-11.0.12.7-hotspot/bin:/c/Windows/system32:/c/Windows:/c/Windows/System32/Wbem:/c/Windows/System32/WindowsPowerShell/v1.0:/c/Windows/System32/OpenSSH:/c/Program Files/dotnet:/c/ProgramData/Chocolatey/bin:/c/Program Files/PowerShell/7:/c/Program Files/Microsoft/Web Platform Installer:/c/Program Files/Microsoft SQL Server/Client SDK/ODBC/170/Tools/Binn:/c/Program Files/Microsoft SQL Server/150/Tools/Binn:/c/Program Files/OpenSSL/bin:/c/Strawberry/c/bin:/c/Strawberry/perl/site/bin:/c/Strawberry/perl/bin:/c/ProgramData/chocolatey/lib/pulumi/tools/Pulumi/bin:/c/Program Files/TortoiseSVN/bin:/c/Program Files/CMake/bin:/c/ProgramData/chocolatey/lib/maven/apache-maven-3.8.6/bin:/c/Program Files/Microsoft Service Fabric/bin/Fabric/Fabric.Code:/c/Program Files/Microsoft SDKs/Service Fabric/Tools/ServiceFabricLocalClusterManager:/c/Program Files/nodejs:/cmd:/mingw64/bin:/usr/bin:/c/Program Files/GitHub CLI:/c/tools/php:/c/Program Files (x86)/sbt/bin:/c/SeleniumWebDrivers/ChromeDriver:/c/SeleniumWebDrivers/EdgeDriver:/c/Program Files/Amazon/AWSCLIV2:/c/Program Files/Amazon/SessionManagerPlugin/bin:/c/Program Files/Amazon/AWSSAMCLI/bin:/c/Program Files/Microsoft SQL Server/130/Tools/Binn:/c/Program Files/LLVM/bin:/c/Users/runneradmin/.dotnet/tools:/c/Users/runneradmin/.cargo/bin:/c/Users/runneradmin/AppData/Local/Microsoft/WindowsApps PYTHONPATH=. TRAC_TEST_DB_URI= server-options= -p 8000 -r -e External dependencies: Git version: git version 2.39.0.windows.1 Subversion version: 1.14.2 ... ====================================================================== ERROR: test_database_version (trac.tests.env.EnvironmentWithoutDataTestCase.test_database_version) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\hostedtoolcache\windows\Python\3.11.1\x64\Lib\shutil.py", line 620, in _rmtree_unsafe os.unlink(fullname) PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'c:\\users\\runneradmin\\appdata\\local\\temp\\trac-testdir-uqx7slhr\\db\\trac.db' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "D:\a\trac\trac\trac\tests\env.py", line 47, in tearDown rmtree(self.env.path) File "D:\a\trac\trac\trac\test.py", line 549, in rmtree shutil.rmtree(path, onerror=onerror) File "C:\hostedtoolcache\windows\Python\3.11.1\x64\Lib\shutil.py", line 759, in rmtree return _rmtree_unsafe(path, onerror) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\hostedtoolcache\windows\Python\3.11.1\x64\Lib\shutil.py", line 617, in _rmtree_unsafe _rmtree_unsafe(fullname, onerror) File "C:\hostedtoolcache\windows\Python\3.11.1\x64\Lib\shutil.py", line 622, in _rmtree_unsafe onerror(os.unlink, fullname, sys.exc_info()) File "D:\a\trac\trac\trac\test.py", line 544, in onerror onerror(function, path, excinfo, retry + 1) File "D:\a\trac\trac\trac\test.py", line 544, in onerror onerror(function, path, excinfo, retry + 1) File "D:\a\trac\trac\trac\test.py", line 544, in onerror onerror(function, path, excinfo, retry + 1) [Previous line repeated 7 more times] File "D:\a\trac\trac\trac\test.py", line 536, in onerror function(path) PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'c:\\users\\runneradmin\\appdata\\local\\temp\\trac-testdir-uqx7slhr\\db\\trac.db' ====================================================================== ERROR: test_invalid_log_type_raises_exception (trac.tests.env.EnvironmentTestCase.test_invalid_log_type_raises_exception) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\hostedtoolcache\windows\Python\3.11.1\x64\Lib\shutil.py", line 620, in _rmtree_unsafe os.unlink(fullname) PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'c:\\users\\runneradmin\\appdata\\local\\temp\\trac-testdir-1imzguf5\\db\\trac.db' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "D:\a\trac\trac\trac\tests\env.py", line 106, in tearDown rmtree(self.env.path) File "D:\a\trac\trac\trac\test.py", line 549, in rmtree shutil.rmtree(path, onerror=onerror) File "C:\hostedtoolcache\windows\Python\3.11.1\x64\Lib\shutil.py", line 759, in rmtree return _rmtree_unsafe(path, onerror) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\hostedtoolcache\windows\Python\3.11.1\x64\Lib\shutil.py", line 617, in _rmtree_unsafe _rmtree_unsafe(fullname, onerror) File "C:\hostedtoolcache\windows\Python\3.11.1\x64\Lib\shutil.py", line 622, in _rmtree_unsafe onerror(os.unlink, fullname, sys.exc_info()) File "D:\a\trac\trac\trac\test.py", line 544, in onerror onerror(function, path, excinfo, retry + 1) File "D:\a\trac\trac\trac\test.py", line 544, in onerror onerror(function, path, excinfo, retry + 1) File "D:\a\trac\trac\trac\test.py", line 544, in onerror onerror(function, path, excinfo, retry + 1) [Previous line repeated 7 more times] File "D:\a\trac\trac\trac\test.py", line 536, in onerror function(path) PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'c:\\users\\runneradmin\\appdata\\local\\temp\\trac-testdir-1imzguf5\\db\\trac.db' ---------------------------------------------------------------------- Ran 2465 tests in 261.398s FAILED (errors=2, skipped=9)
comment:21 by , 2 years ago
Replying to Jun Omae:
Yeah, that's has been reported at #13482 (not yet fixed). I'd like to pin with
Babel<2.10
because I need more time to fix it.
Thanks, I thought it had seemed familiar. Pinning Babel sounds good. I will go ahead and make the 1.4.4 / 1.5.4 releases when you think we are good to proceed.
follow-up: 24 comment:22 by , 2 years ago
comment:23 by , 2 years ago
I got 2 failures with Python 3.11 on Windows.
... PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'c:\\users\\runneradmin\\appdata\\local\\temp\\trac-testdir-1imzguf5\\db\\trac.db' ...
I noticed no failures with Python 3.10 on Windows. I suspect Trac and/or SQLite in Python 3.11 might have something wrong…
comment:24 by , 2 years ago
comment:25 by , 2 years ago
Ok, thank you. Will continue to scour the ticket repository for those that can be included in the release by merit of being ready, beyond a quick visual verification. This would be a self-assigned and non-blocking task.
comment:26 by , 2 years ago
As far as I can tell, this ticket has no effect on Trac core and hence this release, but can be closed nonetheless? #12188
follow-ups: 29 31 comment:28 by , 2 years ago
follow-up: 30 comment:29 by , 2 years ago
Replying to Jun Omae:
Yes. However, I'd like to push changes to switch to GitHub Actions (#13358) before releasing 1.5.4. I'm going to push the changes now.
Good idea. So we can release directly from GitHub actions? Is the only outstanding task on my end comment:13:ticket:13358?
I also favor deleting the Travis CI and AppVeyor configurations since those are no longer functional.
comment:30 by , 2 years ago
Replying to Ryan J Ollos:
Is the only outstanding task on my end comment:13:ticket:13358?
Yes. Setting the key and iv in contrib/travis/id_rsa.enc will automatically upload the sdist and wheel packages to edgewall.org.
See also:
- source:/trunk/.github/workflows/build.yml@17662:453-454#L452
- source:/trunk/.github/release-upload.sh@17662:10
I also favor deleting the Travis CI and AppVeyor configurations since those are no longer functional.
Agreed. I'll delete configuration files for Travis CI and AppVeyor.
follow-up: 32 comment:31 by , 2 years ago
Replying to Jun Omae:
Yes. However, I'd like to push changes to switch to GitHub Actions (#13358) before releasing 1.5.4.
I noticed that GitHub Actions only notify the results the user who called git push
. Therefore the notifications on https://github.com/edgewall/trac are only sent to cboos. It might be good to switch to another user (e.g. edgewall-org) to call git push
, if possible.
comment:32 by , 23 months ago
Replying to Jun Omae:
I noticed that GitHub Actions only notify the results the user who called
git push
. Therefore the notifications on https://github.com/edgewall/trac are only sent to cboos. It might be good to switch to another user (e.g. edgewall-org) to callgit push
, if possible.
I'm hoping this is resolved now.
comment:33 by , 23 months ago
I think we are ready to proceed with doing a test tag and then a real tag to release 1.5.4. I'll update TracDev/ReleaseChecklist as we go. Anything I'm missing?
comment:35 by , 23 months ago
Internal Changes: | modified (diff) |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
Releases are posted to TracDownload#LatestDevRelease. I'll send out the email tomorrow.