#13358 closed enhancement (fixed)
Switch to using Github Actions from Travis CI
Reported by: | Jun Omae | Owned by: | Jun Omae |
---|---|---|---|
Priority: | normal | Milestone: | 1.5.4 |
Component: | general | Version: | |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Restored automatic builds using GitHub Actions. |
Description
Builds with OSX on Travis CI often recently timed out. I think we could be going to use Github Actions.
I'm working it.
- https://github.com/jun66j5/trac/compare/trunk...github-actions
- TODO
- Add jobs on Windows environment
- Port deploy job in .travis.yml
- https://github.com/jun66j5/trac/actions
I noticed one of the downsides which recipient of notifications is not configurable.
Attachments (0)
Change History (21)
comment:1 by , 4 years ago
comment:2 by , 4 years ago
I just found out today that GitHub actions can be run locally. I haven't tried it yet, but it would be very helpful if it works.
comment:3 by , 4 years ago
Proposed changes in log:jomae.git@trunk:github-actions.
OS | Database | Python | Dependencies |
---|---|---|---|
Ubuntu, Macos, Windows | SQLite (in-memory) | 3.9 | minimum, full (included Subversion 1.14.1) |
Ubuntu, Macos, Windows | SQLite | 3.9 | minimum, full (included Subversion 1.14.1) |
Ubuntu, Macos, Windows | PostgreSQL | 3.9 | minimum, full (included Subversion 1.14.1) |
Ubuntu, Macos, Windows | MySQL | 3.9 | minimum, full (included Subversion 1.14.1) |
Ubuntu | SQLite (in-memory) | 3.8, 3.7, 3.6, 3.5 | full (included Subversion 1.14.1) |
- Sample results: https://github.com/jun66j5/trac/actions/runs/663285070
- Test job with MySQL on Windows is very slow
- Functional tests rarely fail
comment:4 by , 4 years ago
Milestone: | 1.6 → 1.5.4 |
---|
follow-up: 7 comment:5 by , 4 years ago
If we get the deploy working on Windows it would address #13190.
comment:6 by , 4 years ago
Milestone: | 1.5.4 → 1.5.5 |
---|
follow-up: 8 comment:7 by , 3 years ago
Replying to Ryan J Ollos:
If we get the deploy working on Windows it would address #13190.
bdist_wininst command has been removed in Python 3.10 (PythonBug:42802). I think we should deploy only sdist and wheel.
Updated branch log:jomae.git@trunk:github-actions.
comment:8 by , 3 years ago
Replying to Jun Omae:
bdist_wininst command has been removed in Python 3.10 (PythonBug:42802). I think we should deploy only sdist and wheel.
Good point, we did drop the win installers from upload to PyPI in recent releases (comment:2:ticket:13205). They weren't generated for Trac 1.4.3. However, they are still created for TracDownload#Trac14StableRelease. I think it makes sense to drop them.
follow-up: 10 comment:9 by , 2 years ago
Owner: | set to |
---|---|
Status: | new → assigned |
We should restore automatic builds using GitHub Actions rather than Travis CI, AppVeyor (long time since automatic builds stopped working)….
comment:10 by , 2 years ago
Replying to Jun Omae:
We should restore automatic builds using GitHub Actions rather than Travis CI, AppVeyor (long time since automatic builds stopped working)….
Sounds great!
follow-up: 19 comment:12 by , 2 years ago
Proposed changes in:
Branch | Changes | Results |
---|---|---|
trunk | jomae.git@trunk:github-actions | actions/runs/3816838152 |
1.4-stable | jomae.git@1.4-stable:github-actions-1.4 | actions/runs/3816783218 |
1.2-stable | jomae.git@1.2-stable:github-actions-1.2 | actions/runs/3820240949 |
1.0-stable | jomae.git@1.0-stable:github-actions-1.0 | actions/runs/3820236150 |
Notes:
- Need to set key and iv of contrib/travis/id_rsa.enc to secrets to upload sdist and wheel files to edgewall.org
- Functional tests with Trac 1.5.x run only on the following environments because the tests are too slow:
- SQLite x (ubuntu-22.04, macos-12) x Python 3.11
- SQLite x windows-2022 x Python 3.10
- On Python 2.7 on Windows, tests for subversion and mysql are skipped because the bindings is unable to build
follow-up: 17 comment:13 by , 2 years ago
Need to set key and iv of contrib/travis/id_rsa.enc to secrets to upload sdist and wheel files to edgewall.org
I will be sure to look into doing it this weekend.
comment:14 by , 23 months ago
Internal Changes: | modified (diff) |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
Committed in [17659-17663].
comment:16 by , 23 months ago
Milestone: | 1.5.5 → 1.5.4 |
---|
follow-up: 18 comment:17 by , 23 months ago
Replying to Ryan J Ollos:
Need to set key and iv of contrib/travis/id_rsa.enc to secrets to upload sdist and wheel files to edgewall.org
I will be sure to look into doing it this weekend.
In addition, could you please add https://github.com
to [wiki] safe_origins
option? I added status badges to wiki:/TracDev/AutomaticBuilds@34, however the badges are not shown due to the option.
comment:18 by , 23 months ago
Replying to Jun Omae:
In addition, could you please add
https://github.com
to[wiki] safe_origins
option? I added status badges to wiki:/TracDev/AutomaticBuilds@34, however the badges are not shown due to the option.
Done! And should have time later today to address my other outstanding tasks.
follow-up: 20 comment:19 by , 23 months ago
follow-up: 21 comment:20 by , 23 months ago
Replying to Ryan J Ollos:
Okay, I think we are ready as of r17670. We can cherry-pick that change to the other branches after confirming it's correct.
Thanks!
I noticed https://svn.edgewall.org/git/trac/mirror is up-to-date (r17671), however https://github.com/edgewall/trac is not up-to-date (r17669). Could you please log of the script which invokes git push
to github?
comment:21 by , 23 months ago
Replying to Jun Omae:
I noticed https://svn.edgewall.org/git/trac/mirror is up-to-date (r17671), however https://github.com/edgewall/trac is not up-to-date (r17669). Could you please log of the script which invokes
git push
to github?
Seems to be resolved now. The post-commit
script doesn't log everything. I should revisit that later.
I like the idea. I've been using GitHub actions for another Python project and had a good experience so far.