some wiki markup produces broken/invalid html, breaks preview, breaks ticket saving

[lp-san@…]

Possible error in wiki markup processing in Trac 1.0.1.

How to reproduce: place the following markup in ticket description:

3. test header
''test text.
test text''

Results: 1) this code transforms to broken html:

    <div class="searchable">
      <ol start="3"><li>test header
</em></li></ol><p>
<em>test text.<br />
test text<em> 2<br />
</em></p>

    </div>

it's completely not well-formed (EM tags are messed up)

2) when updating live-preview, jQuery silently fails to parse data containing this broken markup

3) due to 2, jQuery fails to update ticket draft

4) due to 2, jQuery completely removes the view_time hidden element from the ticket form here:

$("#propertyform input[name='view_time']").replaceWith(items.filter("input[name='view_time']"));

, effectively triggering the error when saving such ticket: Sorry, can not save your changes. This ticket has been modified by someone else (because req.args.get('view_time') is None in trac/ticket/web_ui.py).

Reproduced on demo site: ​http://trac.edgewall.org/demo-1.0/ticket/2503

[Jun Omae]

Thanks for the reporting! 0.12-stable has the same issue.

[Jun Omae]

Proposed fix can be found in log:jomae.git:ticket11373_0.12.6dev.

[lp-san@…]

jomae, thanks a lot for a quick fix!

[Jun Omae]

I found the same issue has been reported in #11009. Also, the proposed changes were not enough to fix it.

[lp-san@…]

Replying to jomae:

I found the same issue has been reported in #11009. Also, the proposed changes were not enough to fix it.

The fix you proposed seems to help my case. Thanks anyway, I'll watch the other ticket.