Bold WikiFormatting leaking outside ticket body

[Andrew C. Martin <andrew.c.martin@…>]

Having the following text in a ticket will result in all subsequent ticket description, comments, and workflow text to default to a bold font weight. The WikiFormatting should not extend past the scope in which it is started.

***
* 
***

Note there is one space on the second line.

I've verified this bug in Trac 0.12.3 and Trac 1.0.1dev-r11320

---

For a demo, see ticket:11009?version=4 (I had to "fix" the description, as this prevented making further changes, at least with Chrome, see comment:5). — cboos

[Andrew C. Martin <andrew.c.martin@…>]

This comment does not have any bold WikiFormatting.

[Andrew C. Martin <andrew.c.martin@…>]

This comment does have bold WikiFormatting.

[Peter Suter]

Seems like a list item immediately followed by some opening tag is broken. Closing the list​ flushes all tags​ including the closing tag corresponding to the opening tag yet to be written. So this also affects e.g. ordered lists and italic text:

1. The list item
//The closing tag that should follow this opening tag was flushed out when closing the list

results in:

<ol><li>The list item
</em></li></ol></p>
<em>The closing tag that should follow this opening tag was flushed out to close the list
</p>

[Christian Boos]

Italic as well, of course, as still visible in ticket:11013?version=0.

And somehow this propagates to breaking the dynamic preview, and sometimes prevent updating the ticket (I couldn't save my change to #11013 until I fixed the formatting of the description, due to the "someone else modified the ticket in the meantime" error). I suppose it's simply due to the broken HTML structure we end up with.

Ah, and same thing here, now.

[Jun Omae]

#11373 was closed as duplicate. Also, proposed changes can be found in log:jomae.git:ticket11009_0.12.6dev.

[Jun Omae]

#11373 was closed as duplicate. Also, proposed changes can be found in log:jomae.git:ticket11009_0.12.6dev.

Could someone review the patch?

[Peter Suter]

Close list before checking open tags.

[Peter Suter]

Replying to jomae:

log:jomae.git:ticket11009_0.12.6dev.

Could someone review the patch?

Looks almost good to me.

But I think _indirect_tag_handler should first close any lists if needed and only then check if the tag is already open. Otherwise the following fails:

 1. //italic in list
//italic
in paragraph

With your patch _indirect_tag_handler:

1. First checks if the // tag is open (yes)
2. Then closes the list (this flushes and closes the open // tag)
3. Attempts to close the // tag again (because the check in 1. said yes).

Fixing this actually simplifies the code. I added this testcase, the simplified _indirect_tag_handler and a similar simplification of _bolditalic_formatter to your code in the attached patch​.

[Jun Omae]

Fixing this actually simplifies the code. I added this testcase, the simplified _indirect_tag_handler and a similar simplification of _bolditalic_formatter to your code in the attached patch​.

Thanks for reviewing. Your patch looks pretty good rather than my patch. Please commit!

[Peter Suter]

Committed in [12549] and merged in [12550-12551].