Opened 11 years ago
Last modified 15 months ago
#11374 new defect
Image macro doesn't display image containing a colon
Reported by: | Ryan J Ollos | Owned by: | |
---|---|---|---|
Priority: | normal | Milestone: | next-stable-1.6.x |
Component: | wiki system | Version: | |
Severity: | normal | Keywords: | imagemacro |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
For example, see the attachment:
[[Image(2013-11-19_19:34:53.png)]]
Attachments (1)
Change History (8)
by , 11 years ago
Attachment: | 2013-11-19_19:34:53.png added |
---|
comment:1 by , 11 years ago
comment:2 by , 11 years ago
#10562 was fixed to show image for page name with colon characters and allows to enclose quote characters the page name.
[[Image("page:fr":image.png)]]
comment:3 by , 11 years ago
Thanks, I was searching for an existing ticket because I thought the issue sounded familiar, and #10562 is the one I was barely remembering.
comment:4 by , 10 years ago
I tried resolving this case in [13787] when fixing #8168, however I couldn't come up with a solution to both. Outer quotes are stripped before splitting at the colon to handle the case of a quoted URI branches/1.0-stable/trac/wiki/macros.py@13793:#L594 (e.g. "http://trac.edgewall.org/attachment/ticket/13374/file"
or "data:image/png;base64,iVBORw0KGgoAA"
). However, in a case like [[Image("page:fr":"ima:ge.png")]]
we would not want to strip off the outer quotes.
comment:5 by , 8 years ago
Milestone: | next-stable-1.0.x → next-stable-1.2.x |
---|
Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.
comment:6 by , 5 years ago
Milestone: | next-stable-1.2.x → next-stable-1.4.x |
---|
This is not too surprising since the colon is used as the realm and resource separator, but maybe we should at least allow an escape character to be used like on the filesystem
2013-11-19_19\:34\:53.png
. I only noticed because the example shown is a truncated version of the default filename that is created by the Screenshot tool on Ubuntu.