Edgewall Software
Modify ↓

Opened 14 years ago

Closed 10 years ago

Last modified 8 years ago

#9485 closed defect (duplicate)

repository_sync_per_request seems to be ignored with multiple hg repositories

Reported by: vincent@… Owned by: Christian Boos
Priority: normal Milestone:
Component: plugin/mercurial Version: 0.12
Severity: normal Keywords:
Cc: leho@…, mmitar@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by anonymous)


Attachments (0)

Change History (11)

comment:1 by Remy Blank, 14 years ago

Resolution: → worksforme
Status: new → closed

Yes, this is due to the fact that the Mercurial plugin doesn't cache the changeset metadata in the database, so the sync() operation is a no-op and any change to the repository is directly visible in Trac.

We don't really want to advertise this, as it may change in a future version of the plugin. And actually, the same applies if you configure a Subversion repository with the type direct-svnfs, where no caching is done (but performance is bad).

comment:2 by awagner@…, 14 years ago

Resolution: worksforme
Status: closed → reopened

Would this cause TracSearch for changesets to come up empty since nothing is cached?

I have numerous mercurial repositories (no hooks) and when I look in the sqlite db I've got an empty revision table.

Is this by design? Should I add hooks to all 100+ repos? Should this be a new defect ticket? Any advice?

in reply to:  2 comment:3 by Christian Boos, 14 years ago

Replying to awagner@…:

Should this be a new defect ticket? Any advice?

This is #8417.

Should I add hooks to all 100+ repos?

Yes, once #8417 is implemented.

comment:4 by Remy Blank, 14 years ago

Yes, search functionality requires caching, so searching currently doesn't work with Mercurial. It's not by design, it's only because it hasn't been implemented yet for that backend.

Adding hooks for Mercurial repositories still makes sense if you have plugins that use the repository change listener functionality, like the TicketCommitUpdater.

comment:5 by lkraav <leho@…>, 14 years ago

Cc: leho@… added

in reply to:  4 comment:6 by Christian Boos, 14 years ago

Component: plugin/mercurial → version control/changeset view
Milestone: → 0.13
Owner: set to Christian Boos
Status: reopened → new

Replying to rblank:

Yes, search functionality requires caching, so searching currently doesn't work with Mercurial.

And as such, moving the changeset search provider to cache.py is one TODO.

Reusing this ticket for that, as otherwise it's a duplicate of #8417 (unless I missed something).

comment:7 by Mitar, 14 years ago

Cc: mmitar@… added

comment:8 by Remy Blank, 13 years ago

Milestone: 1.0 → 1.0-triage

Preparing for 1.0.

comment:9 by Ryan J Ollos, 10 years ago

Component: version control/changeset view → plugin/mercurial
Milestone: next-stable-1.0.x
Resolution: → duplicate
Status: new → closed

Closing as a duplicate of #8417. Ticket #12068 has been created to address comment:6.

in reply to:  9 comment:10 by Ryan J Ollos, 9 years ago

Replying to rjollos:

Ticket #12068 has been created to address comment:6.

But turns out #10764 already exists to address comment:6.

comment:11 by anonymous, 8 years ago

Description: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.