Edgewall Software
Modify

Opened 8 years ago

Last modified 5 years ago

#10764 new defect

refactor changeset search

Reported by: Christian Boos Owned by:
Priority: normal Milestone: next-major-releases
Component: version control Version: 1.0dev
Severity: major Keywords: search
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Currently it's done at the level of the ChangesetModule, assuming all the data is in the database's revision table!

(see trunk/trac/versioncontrol/web_ui/changeset.py@11093#L1143)

Obviously this won't work for non-cached repositories. The current implementation needs to be moved to the cached repository and each repository should be able to provide results (or not, e.g. on a per repository basis depending on some settings, like don't search that non-cached linux repo, as it's too big).

Attachments (0)

Change History (3)

comment:1 by Ryan J Ollos, 5 years ago

Owner: Christian Boos removed

in reply to:  description comment:2 by Ryan J Ollos, 5 years ago

Replying to cboos:

… and each repository should be able to provide results (or not, e.g. on a per repository basis depending on some settings, like don't search that non-cached linux repo, as it's too big).

This would seem to suggest that cached should be a per-repository property. I've previously considered that this would be a good feature since it would also allow us to unify the "cached" setting for Git and SVN. Currently non-cached SVN repositories are specified using the type direct-svnfs, and non-cached Git repositories are specified using the setting [git] cached_repository = False. It would be simpler to specify cached using a property, e.g. <repository>.cached = False.

comment:3 by Ryan J Ollos, 5 years ago

#12068 was closed a duplicate. #12068 was created in response to #9485.

comment:4:ticket:12068 has a good suggestion to add search_changesets to the Repository class.

Last edited 5 years ago by Ryan J Ollos (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.