Opened 13 years ago
Closed 11 years ago
Last modified 11 years ago
#9366 closed enhancement (fixed)
Permissions screen is confusing when there are large groups
|Reported by:||batrick||Owned by:|
|Severity:||normal||Keywords:||bitesized patch review|
|Cc:||franoleg@…, osimons, ryano@…||Branch:|
Separated permissions and group memberships in the permission admin panel.
We use trac with approximately 10 groups and 150 users. Functionally, everything works fine but the permissions screen is confusing because it shows one row per user (so there are approximately 160 rows shown, including the rights for each group).
It would be a fine usability enhancements if group memberships were, in fact, shown by group. In this case, there would be only 10 lines for permissions, and 10 for group memberships.
Change History (12)
comment:1 by , 13 years ago
comment:2 by , 11 years ago
I'm submitting a patch which implements this proposal (screenshot included). Changes are primarily in the Genshi template, which now lists
groups as separate
tbodys. Code only places the
perms and the
Form logic was not modified.
There are some changes in the CSS that I made in order to put subheadings within the table (I wanted the column widths to be the same, hence one table instead of two, a la #9825). I feel these changes can be done better. Any feedback so I can improve the patch?
by , 11 years ago
Permissions and group membership are displayed as two tables, instead of one (against trunk).
by , 11 years ago
A screenshot of separated tables.
comment:3 by , 11 years ago
|Keywords:||patch review added|
comment:4 by , 11 years ago
|Milestone:||unscheduled → 0.13|
|Priority:||normal → high|
That looks nice! Thanks for the patch.
comment:5 by , 11 years ago
comment:6 by , 11 years ago
comment:7 by , 11 years ago
comment:8 by , 11 years ago
|Status:||new → closed|
Improved patch applied in , together with some cleanup. In particular:
- XHTML doesn't allow multiple
<thead>sections in a
<body>are forbidden as well.
- Put the
<label>, allowing to remove the
id=attribute, and with the advantage that clicking between the checkbox and the label will actually trigger the checkbox.
Thanks Oleg, your patch was an excellent starting point. I like the new layout very much.
comment:9 by , 11 years ago
comment:10 by , 11 years ago
|Release Notes:||modified (diff)|
This sounds like a nice idea.