Edgewall Software
Modify

Opened 12 years ago

Closed 12 years ago

Last modified 4 years ago

#9023 closed defect (fixed)

"trac-admin upgrade" to upgrade README and kill wiki-macros/

Reported by: anatoly techtonik <techtonik@…> Owned by: Remy Blank
Priority: normal Milestone: 0.12
Component: admin/console Version:
Severity: normal Keywords: needpatch
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

trac-admin upgrade should remove obsolete wiki-macros/ directory if it is empty and give warning if it is not. It should also patch README in environment root. Any other non-db upgrades?

  • README

    old new  
    1 This directory contains a Trac project.
    2 Visit http://trac.edgewall.com/ for more information.
     1This directory contains a Trac environment.
     2Visit http://trac.edgewall.org/ for more information.

Attachments (0)

Change History (8)

comment:1 by Christian Boos, 12 years ago

Keywords: needpatch added
Milestone: 0.11.70.12

Can you come up with a patch with the remove obsolete wiki-macros/ directory if it is empty and give warning if it is not part?

And also, don't fail but only warn if the directory can't be deleted.

comment:2 by Remy Blank, 12 years ago

Resolution: fixed
Status: newclosed

wiki-macros is now removed if empty in [9249], or a warning is displayed if it is non-empty or if removing it fails.

I'd say we leave the README file as-is, though. Too little value.

comment:3 by Remy Blank, 12 years ago

Owner: set to Remy Blank

comment:4 by Christian Boos, 12 years ago

It should be possible to refactor this a bit in order to have only one message, as they're close enough (think about the poor translators ;-) ).

comment:5 by Remy Blank, 12 years ago

I thought that it was combining messages from parts that was the translator's nightmare…

comment:6 by Ryan J Ollos, 5 years ago

What do you think about moving the code in r9249 to a dbN.py upgrade step? The operation seems to fit the pattern of a dbN upgrade step.

comment:7 by Christian Boos, 5 years ago

Maybe we could start to switch to an alternative naming scheme for the upgrade steps (012_*.py) e.g. 04x_remove_wiki_macros.py here.

in reply to:  7 comment:8 by Ryan J Ollos, 4 years ago

Replying to Christian Boos:

Maybe we could start to switch to an alternative naming scheme for the upgrade steps (012_*.py) e.g. 04x_remove_wiki_macros.py here.

Trac 0.12 added db22.py to db26.py. Do you mean that the added step would be something like db26_remove_wiki_macros.py?

The way the upgrades are implemented right now is rather nice because it's very simple and handled by DatabaseManager.upgrade. Maybe we should just move the code into an existing step? It only needs to be executed if upgrading from Trac < 0.12.

See also #12824.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Remy Blank.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Remy Blank to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.