Edgewall Software

Opened 4 years ago

Closed 4 years ago

Last modified 18 months ago

#12824 closed defect (fixed)

basic-workflow is not restored on environment upgrade

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.3.2
Component: general Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:
  • The workflow is upgraded in db21.py rather than ConfigurableTicketWorkflow.upgrade_environment.
  • The wiki-macros directory is removed in db26.py rather than EnvironmentAdmin._do_upgrade.

Description (last modified by Ryan J Ollos)

The [ticket-workflow] section is restored on environment upgrade, if missing. While the basic-workflow.ini is used to create the environment, the original-workflow.ini is used on environment upgrade ([5731#file9]). The original-workflow.ini does not have a ticket create action (#2045).

It appears to just be a side-effect of the IEnvironmentSetupParticipant implementation that the [ticket-workflow] is restored after deleting it. The behavior is rather strange because most likely the user was running basic-workflow.ini or a custom workflow, but original-workflow.ini gets restored.

Proposed changes:

  1. DONE Add ticket create actions to original-workflow.ini
  2. Move handling of upgrade from pre-0.11 to a step in the upgrade module. comment:7:ticket:9023 is relevant to how we handle this.
  3. Either restore basic-workflow or do nothing when there is no [ticket-workflow] section in trac.ini. #12642 will handle warnings when there are no workflow actions.

Attachments (0)

Change History (5)

comment:1 by Ryan J Ollos, 4 years ago

Considering something like these untested changes: rjollos.git:t12824_add_upgrade_steps.

original-workflow.ini was fixed on 1.2-stable in r15969, merged to trunk in r15970.

Last edited 4 years ago by Ryan J Ollos (previous) (diff)

comment:2 by Ryan J Ollos, 4 years ago

Description: modified (diff)

comment:3 by Ryan J Ollos, 4 years ago

Milestone: next-dev-1.3.x1.3.2
Release Notes: modified (diff)

comment:4 by Ryan J Ollos, 4 years ago

Resolution: fixed
Status: assignedclosed

Committed to trunk in r16010. I tested the upgrade steps from a 0.10.5 environment, upgraded to trunk (db44.py).

comment:5 by Ryan J Ollos, 18 months ago

Internal Changes: modified (diff)
Release Notes: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.