Edgewall Software
Modify

Opened 8 years ago

Closed 7 years ago

Last modified 5 years ago

#12642 closed enhancement (fixed)

Notice when no actions started with <none> status in workflow

Reported by: Jun Omae Owned by: Ryan J Ollos
Priority: normal Milestone: 1.3.3
Component: ticket system Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
  • Ticket preview is disabled when there are no workflow actions.
  • The default reset action is not added if there is no new state in the workflow.
API Changes:
Internal Changes:

Description

If ticket-workflow has no actions started with <none> status, Action in newticket page would be blank. As a result, it would be unable to create new ticket.

The following warning would be shown after submitting:

I think we should some warning message for ticket-workflow in Action area should be shown. Thoughts?

Attachments (2)

blank-action.png (6.1 KB ) - added by Jun Omae 8 years ago.
warning-on-create.png (2.4 KB ) - added by Jun Omae 8 years ago.

Download all attachments as: .zip

Change History (8)

by Jun Omae, 8 years ago

Attachment: blank-action.png added

by Jun Omae, 8 years ago

Attachment: warning-on-create.png added

in reply to:  description comment:1 by Ryan J Ollos, 8 years ago

Replying to Jun Omae:

I think we should some warning message for ticket-workflow in Action area should be shown. Thoughts?

Yes, that sounds good, and maybe also disable the Create ticket button (and Preview button, if it also results in the The action "None" is not available warning).

comment:2 by Jun Omae, 8 years ago

There is similar issue when no actions for current status on Trac 1.0.x. The action "view" is not available warning would be shown. Of course, view action is not used in workflow but is used as default of action parameter at tags/trac-1.0.13/trac/ticket/web_ui.py@:534-535#L518. This behavior confused me.

comment:3 by Ryan J Ollos, 7 years ago

Owner: set to Ryan J Ollos
Status: newassigned

comment:4 by Ryan J Ollos, 7 years ago

Milestone: next-stable-1.2.x1.3.3

I've prepared changes in [70cafab33/rjollos.git]. I don't want to spend the time to backport to 1.2-stable and 1.0-stable since the issue only occurs with incorrect configuration, but feel free to backport if it's important.

I'll add tests before committing.

comment:5 by Ryan J Ollos, 7 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Fixed in r16243.

comment:6 by Ryan J Ollos, 5 years ago

Fixed incorrect test case in r17326, merged in r17327.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.