Use TicketChangeListener infrastructure for ticket notifications

[Felix Schwarz <felix.schwarz@…>]

Currently the ticket notification system is completely separate from the TicketChangeListener infrastructure so that the notification code needs to be duplicated everywhere if the user should be notified of a change.

The general consensus seems to be that the notification system needs to be cleaned up so this could be the first step in that direction:

• ​http://groups.google.com/group/trac-dev/msg/25ccafab5d89ed02
• ​http://groups.google.com/group/trac-dev/browse_thread/thread/c0c2a185715f18dc

[Remy Blank]

Looks like a good start. One issue I can see is that with the patch, a component that changes a ticket cannot prevent sending notifications. For example, the commit_ticket_updater plugin in multirepos has a configuration option to allow not sending notifications for changes due to automatic ticket updates from commit messages.

[Felix Schwarz <felix.schwarz@…>]

This is an additional cleanup patch which just refactors the code a bit

[Felix Schwarz <felix.schwarz@…>]

Replying to rblank:

Looks like a good start. One issue I can see is that with the patch, a component that changes a ticket cannot prevent sending notifications. For example, the commit_ticket_updater plugin in multirepos has a configuration option to allow not sending notifications for changes due to automatic ticket updates from commit messages.

This is indeed a problem. My feeling is that we need probably additional infrastructure in the TicketNotificationSystem or NotificationSystem so that external plugins can temporarily disable email notifications. The other option would be that you pass additional flags in ticket.save_changes and handle listeners differently which I don't like.

Any suggestions?

[Remy Blank]

This is actually a duplicate of #7758, and the issue in comment:1 is also discussed there.