#8003 closed defect (fixed)
TracBrowser 'o' key fails to follow .. link
Reported by: | Owned by: | Christian Boos | |
---|---|---|---|
Priority: | normal | Milestone: | 0.11.4 |
Component: | version control/browser | Version: | 0.11 |
Severity: | minor | Keywords: | tracbrowser keyboard accesskey |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
The problem
In TracBrowser you can use 'j', 'k' and 'o' keys to navigate with the keyboard.
Unfortunately, on the '..' link to go up, the 'o' key makes the browser go to an undefined page.
It seems that the link is appended with the 'undefined' string.
Error on Trac site
This produce the following error on Trac (http://trac.edgewall.org/) installed with unknown version (strangely removed from pages…):
Trac Error
<p class="message">No node /sandbox/undefined at revision 7803</p><p>You can <a href="/log/sandbox/undefined?rev=7803&mode=path_history">search</a> in the repository history to see if that path existed but was later removed</p>
TracGuide — The Trac User and Administration Guide
Error on my setup (Trac 0.11.1)
This produce the following error my Trac installed with 0.11.1 version:
Trac Error
No node /trunk/doc/undefined at revision 430
You can search in the repository history to see if that path existed but was later removed
TracGuide — The Trac User and Administration Guide
Attachments (0)
Change History (8)
comment:1 by , 16 years ago
Resolution: | → duplicate |
---|---|
Status: | new → closed |
comment:2 by , 16 years ago
comment:3 by , 16 years ago
If you think the patch fixes the problem, ok. But I cannot test a patch. As I'm in a production environment.
In which release can I except it to be available ?
comment:4 by , 16 years ago
Milestone: | → 0.11.3 |
---|---|
Resolution: | duplicate |
Severity: | normal → minor |
Status: | closed → reopened |
Version: | → 0.11 |
As the ticket says, 0.12.
The specific part which fixes the issue raised here can be backported to 0.11.3:
} else { - window.location = selection.find('a.file').attr('href'); + var href = selection.find('a.file').attr('href'); + if (href) { + if (event.keyCode == 65) + href += '?annotate=blame'; + } else { + href = selection.find('a.parent').attr('href'); + } + if (href) + window.location = href; }
comment:7 by , 16 years ago
Owner: | set to |
---|
comment:8 by , 11 years ago
Keywords: | accesskey added |
---|
Yep, known issue. I'd be pleased if you could test the (last) patch on #7074, which fixes this problem among other things.