Edgewall Software
Modify

Opened 11 years ago

Closed 11 years ago

Last modified 6 years ago

#8003 closed defect (fixed)

TracBrowser 'o' key fails to follow .. link

Reported by: michelbriand@… Owned by: Christian Boos
Priority: normal Milestone: 0.11.4
Component: version control/browser Version: 0.11
Severity: minor Keywords: tracbrowser keyboard accesskey
Cc: Branch:
Release Notes:
API Changes:

Description

The problem

In TracBrowser you can use 'j', 'k' and 'o' keys to navigate with the keyboard.

Unfortunately, on the '..' link to go up, the 'o' key makes the browser go to an undefined page.

It seems that the link is appended with the 'undefined' string.

Error on Trac site

This produce the following error on Trac (http://trac.edgewall.org/) installed with unknown version (strangely removed from pages…):

Trac Error

<p class="message">No node /sandbox/undefined at revision 7803</p><p>You can <a href="/log/sandbox/undefined?rev=7803&amp;mode=path_history">search</a> in the repository history to see if that path existed but was later removed</p>

TracGuide — The Trac User and Administration Guide

Error on my setup (Trac 0.11.1)

This produce the following error my Trac installed with 0.11.1 version:

Trac Error

No node /trunk/doc/undefined at revision 430

You can search in the repository history to see if that path existed but was later removed

TracGuide — The Trac User and Administration Guide

Attachments (0)

Change History (8)

comment:1 by Christian Boos, 11 years ago

Resolution: duplicate
Status: newclosed

Yep, known issue. I'd be pleased if you could test the (last) patch on #7074, which fixes this problem among other things.

comment:2 by Christian Boos, 11 years ago

Ah yes, about the "strange" error you saw here (Trac running 0.11stable-r7784): this is something which happened during 0.11-stable development, not in a released version. It is now fixed (r7794).

comment:3 by anonymous, 11 years ago

If you think the patch fixes the problem, ok. But I cannot test a patch. As I'm in a production environment.

In which release can I except it to be available ?

comment:4 by Christian Boos, 11 years ago

Milestone: 0.11.3
Resolution: duplicate
Severity: normalminor
Status: closedreopened
Version: 0.11

As the ticket says, 0.12.

The specific part which fixes the issue raised here can be backported to 0.11.3:

           } else {
-            window.location = selection.find('a.file').attr('href');
+            var href = selection.find('a.file').attr('href');
+            if (href) {
+              if (event.keyCode == 65)
+                href += '?annotate=blame';
+            } else {
+              href = selection.find('a.parent').attr('href');
+            }
+            if (href)
+              window.location = href;
           }

comment:5 by Christian Boos, 11 years ago

(copy/pasted, also needs removal of the 'a' → blame part)

comment:6 by Christian Boos, 11 years ago

Resolution: fixed
Status: reopenedclosed

Fixed in r7918.

comment:7 by Christian Boos, 11 years ago

Owner: set to Christian Boos

comment:8 by anonymous, 6 years ago

Keywords: accesskey added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.