Source browser subdirectories unexpand when returning to the page

[Peter_Schwer@…]

To reproduce the issue:

1. Go to the source browser and expand a directory therein.
   

2. Click on a file in the directory to view.
   

3. After the source viewer appears, press the "Back" button on your browser.
   

4. Observe that the previously expanded directory has returned to an unexpanded state.
   

Browser version: Firefox 2.0.0.13

OS: Windows XP

My version of Trac is served on ubuntu gutsy-apache2-mod_python.

[Christian Boos]

Right, it would be cool if it worked like that.

If someone finds a cheap way to implement that, let me know ;-)

[gunnar_thielebein@…]

I recently did a post which also complies to this featurerequest ​http://groups.google.de/group/trac-dev/browse_thread/thread/df6a35486e0c9c2c

[Christian Boos]

Using a fragment containing the path to the last opened folder would indeed be a good compromise. Thanks for the idea!

[Christian Boos]

Implements this feature and a bunch of other minor improvements (patch on trunk r7672)

[Christian Boos]

I have a patch queue implementing several improvements for the directory expansion feature:

• make it possible to reload (error) rows
• more keybindings for the keyboard navigation:
  • 'a' for annotate
  • 'l' for changelog
  • 'r' for reloading an already expanded folder (useful when viewing the latest version)
• fixed keyboard navigation to the upper directory
• and finally, the feature requested here (restore latest expanded folder to its expanded state when going back to a browser page)

Note that this won't restore all the expanded folders, that would probably be overkill, but only the latest expanded one.

Note: for reviewing/testing, I simply snapshotted all the changes at once with a svn diff (attachment:7074-directory-expand-and-nav.patch​). If there's anything wrong, I'll fix the corresponding patch. In case anyone would prefer to see the full patch stack, just ask.

[Christian Boos]

Incredible how posting code helps you to find bugs immediately afterwards ;-) Same as before, also re-expands correctly when browsing from another place than the root and when there are query arguments (non-default sort order, fixed rev, etc.)

[Christian Boos]

#8003 mentioned the problem with 'o'pening the ".." entry with the browser keyboard shortcut, which incidentally is also fixed in this patch.

[Christian Boos]

Finally committed that patch stack.

Relevant changesets for this specific feature are [7979] and [7980].