source links doesn't handle space anymore

[micke@…]

In 0.6 at least it was possible to have a source:Foo%20Bar link when the fdirectory was named "Foo Bar". Trunk doesn't seem to like that very much.

[wallylynn@…]

I noticed the same thing when I updated my 0.7.1 to 0.8. The manually encoded spaces in my links are reencoded from %20 to %2520 (aka. the "%" gets encoded). After reviewing the timeline, I found what I think to be the cause: ticket #690 and corresponding changeset [864]

I undid the change on my local install and the %20 works now. Thank you, version control! Obviously, I need to be wary of other characters in my filenames now.

Since Trac uses the space as a delimiter, I will try to make "%20" a special case. I'll try to decode it back to a space and let the python library do it's work to reencode it.

[kevin@…]

Here's a reasonable solution. The problem is that you can't have TracLinks including raw spaces, because the space ends the link. So you have to encode it as %20. But then that gets re-encoded into %2520 when the URL itself is url-encoded. However, any other character is valid in a link so you don't have to encode those.

So basically, the easiest solution is to do a simple string substitution on the link, turning "%20" into " ", before running it through the url encoding. You should be able to stick this right before each new line from [864] and be done.

[Mark Rowe]

Resolved in [1398]. Thanks for the report and feedback.

[SoloTurn]

it does not seem to work with urls like ​program files

[Christian Boos]

That behavior was changed on purpose in r3143. See the corresponding commit log message for further details.

[Christian Boos]

(clearing report:35)