unicode decode error on `WebAdmin - Plugins` page

[trac-ja@…]

looks like #6890. WebAdmin - plugins page fails, if plugines's docstring has non-ASCII chars.

Patch:

trac/admin/web_ui.py

@@ -30 +30 @@
 from trac.perm import PermissionSystem, IPermissionRequestor
 from trac.util import get_pkginfo, get_module_path
 from trac.util.compat import partial
+from trac.util.text import to_unicode
 from trac.util.translation import _
 from trac.web import HTTPNotFound, IRequestHandler
 from trac.web.chrome import add_script, add_stylesheet, add_warning, Chrome, \
@@ -480 +481 @@
             if os.path.realpath(os.path.dirname(dist.location)) == plugins_dir:
                 plugin_filename = os.path.basename(dist.location)
 
-            description = inspect.getdoc(component)
+            description = to_unicode(inspect.getdoc(component))
             if description:
                 description = description.split('.', 1)[0] + '.'
 

[osimons]

Ideally plugins should provide unicode strings if they have non-ascii characters in any strings.

However, better safe than sorry, I suppose - certainly for such a minor fix.

I'll get onto it.

[osimons]

Thanks for the patch - tested and committed in [6667].