Custom checkbox field not selectable in IE

[peter@…]

I have added a custom ticket field which is a simple checkbox by adding the following section to the trac.ini:

[ticket-custom]
tested = checkbox
tested.label = Testing completed
tested.value = 0

When using the Custom Query this field is available for selection from the Add Filter combo box. If you are using Internet Explorer (only tested using IE7) the field appears with radio buttons for Yes and No but they are not selectable.

When the update button is clicked the fields options disappear, even though any other selected fields remain visible.

Adding this filter works fine with Firefox, the Yes and No options are both selectable and remain visible after an update.

[osimons]

The Trac javascript code creates the table elements and the various fields as required. I have reviewed the relevant parts, and it looks correct and behaves correctly in Firefox as you say.

However, viewing the DOM source with IE Developer Toolbar it shows this - clearly missing the name="tested" attribute that is supposed to name and group these two radio buttons:

<TD class="filter" colSpan="2">
  <INPUT id="tested_on" type="radio" value="1" />
  <LABEL for="tested_on">yes</LABEL>
  <INPUT id="tested_off" type="radio" value="0" />
  <LABEL for="tested_off">no</LABEL>
</TD>

Tested using an up-to-date IE7. Verified bug using 0.11b1+, so it is not related to Trac version.

It feels like (another) IE bug…

[osimons]

Looks like it:

​http://webbugtrack.blogspot.com/2007/10/bug-235-createelement-is-broken-in-ie.html

This modification makes it work:

trac/htdocs/js/query.js

@@ -130 +130 @@
 
     // Convenience function for creating an <input type="radio">
     function createRadio(name, value, id) {
-      var input = document.createElement("input");
+      if (!$.browser.msie) {
+        var input = document.createElement("input");
+      } else {
+        var input = document.createElement('<input name="'+name+'"/>');
+      }
       input.type = "radio";
       if (name) input.name = name;
       if (value) input.value = value;}}}

Should we update the js createElement() code to use this quirky workaround, or any better ideas? Does jQuery contain a useful multi-browser 'create' method? Hmm. I better start reading up on jQuery, I suppose…

[osimons]

Turns out to be a duplicate - not surprising really as the bug seems to have been there for a long time.

Closing as duplicate of #3014.

[Paul Irish <paul.irishEWWSPAM@…>]

revised radio button creation using innerHTML

[Paul Irish <paul.irishEWWSPAM@…>]

oops. wrong ticket.

btw, osimons- the jQuery syntax for element creation is simply $('<input type="radio" name="foo"/>) — It's just putting a string of abitrary html as the primary argument. It'll be constructed into the neccessary DOM nodes. IMO, it wouldn't work well here unless we redid a big chunk of it.