Opened 19 years ago
Closed 17 years ago
#3014 closed defect (fixed)
IE specific - Problems with Custom Query about Checkbox Custom Fields
| Reported by: | Owned by: | osimons | |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.11 |
| Component: | ticket system | Version: | 0.9.4 |
| Severity: | normal | Keywords: | query ie radio |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
With IE 6 on Windows XP, custom queries do not work properly with checkbox custom fields. The filter shows up with 'yes' and 'no' radio buttons, but I cannot select either radio button using IE.
Firefox works fine.
Attachments (3)
Change History (15)
by , 19 years ago
| Attachment: | trac-0.9.5-ie-dynamic-radio-fix.diff added |
|---|
comment:1 by , 19 years ago
Turns out this is an IE bug. You just simply cannot select dynamically created radio buttons. I found a work-around at http://cf-bill.blogspot.com/2006/03/another-ie-gotcha-dynamiclly-created.html.
attachment:trac-0.9.5-ie-dynamic-radio-fix.diff fixes the problem. It's ugly, but that's the way things go in the browser compatability game.
comment:2 by , 19 years ago
| Milestone: | → 0.9.6 |
|---|
Maybe if I set the milestone on this bug it will get some attention…
comment:3 by , 19 years ago
| Component: | report system → ticket system |
|---|---|
| Keywords: | query added |
| Milestone: | 0.9.6 → 0.10 |
| Owner: | changed from to |
| Status: | new → assigned |
Ouch, that is another rather awful bug in our beloved browser. If I read the post you linked to correctly, the patch won't work in Opera because it doesn't raise an exception. I'll play with this and try to find something workable.
comment:4 by , 18 years ago
| Milestone: | 0.10 → 0.10.1 |
|---|
comment:6 by , 18 years ago
The best fix would probably be a mix of mine and the original one. In particular only type and name need to be put in the tag passed into createElement for IE.
comment:7 by , 17 years ago
| Keywords: | ie radio added |
|---|---|
| Milestone: | 0.10.5 → 0.11.1 |
#6778 closed as a duplicate.
comment:ticket:6778:2 has arrived at the same workaround, and has an example pattern for use with current trunk (jQuery).
by , 17 years ago
| Attachment: | trac-ie-dynamic-radio-fix.diff added |
|---|
revised radio button creation using innerHTML
follow-up: 9 comment:8 by , 17 years ago
Patch uses innerHTML to create the radio inside a wrapper SPAN. This avoids browser sniffing, which is a messy game to play.
Tested here in ie6, ie7, ff2, saf3.
comment:9 by , 17 years ago
| Owner: | changed from to |
|---|---|
| Status: | assigned → new |
Replying to Paul Irish <paul.irishEWWSPAM@gmail.com>:
Patch uses innerHTML to create the radio inside a wrapper SPAN. This avoids browser sniffing, which is a messy game to play.
Tested here in ie6, ie7, ff2, saf3.
Superb! Works fine for me on same set of browsers + opera9. Any solution that makes it work without browser sniffing is a "go" from me :-)
Further comments before I commit?
comment:10 by , 17 years ago
Yes, wait 15 more minutes or so if you don't mind, as I'd like to get my next commits grouped with r6633 ;-)
comment:12 by , 17 years ago
| Milestone: | 0.11.1 → 0.11 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Latest patch comitted as [6636].
Potential fix