hotcopy fails in 0.11b1 on Windows with pysqlite-2.4.0

[goran.wallgren@…]

This bug is closely related to #1123 - it has reappeared because of a new journal file in that (newer) version of SQLite.

It can hopefully be solved in the same way: if the journal file is not needed for a hotcopy, it can be added to the "skip" list inside "Python/Lib/site-packages/trac/admin/console.py".

Here are the errors I received:

Hotcopying E:\Dev\trac\susrepo1.db to e:/Dev/Backups/susrepo1.db.trac_hotcopy ..
.
Traceback (most recent call last):
  File "E:\dev\python24\scripts\trac-admin-script.py", line 7, in ?
    sys.exit(
  File "E:\Dev\Python24\Lib\site-packages\trac\admin\console.py", line 1194, in
run
    return admin.onecmd(command)
  File "E:\Dev\Python24\Lib\site-packages\trac\admin\console.py", line 102, in o
necmd
    rv = cmd.Cmd.onecmd(self, line) or 0
  File "E:\Dev\Python24\Lib\cmd.py", line 219, in onecmd
    return func(arg)
  File "E:\Dev\Python24\Lib\site-packages\trac\admin\console.py", line 1140, in
do_hotcopy
    copytree(self.__env.path, dest, symlinks=1, skip=skip)
  File "E:\Dev\Python24\Lib\site-packages\trac\admin\console.py", line 64, in co
pytree
    copytree(srcname, dstname, symlinks, skip)
  File "E:\Dev\Python24\Lib\site-packages\trac\admin\console.py", line 71, in co
pytree
    raise shutil.Error, errors
shutil.Error: [('E:\\Dev\\trac\\susrepo1.db\\db\\trac.db-stmtjrnl', u'e:/Dev/Bac
kups/susrepo1.db.trac_hotcopy\\db\\trac.db-stmtjrnl', <exceptions.IOError instan
ce at 0x01005D50>)]

[anonymous]

Sorry, my email address is goran.wallgren@…

[goran.wallgren@…]

To clarify, the name of the new journal file is "trac.db-stmtjrnl"

A quick fix is to replace the line

skip = ['%s-journal'  % os.path.join(self.__env.path, db_path)]

with

skip = ['%s-journal'  % os.path.join(self.__env.path, db_path),
        '%s-stmtjrnl' % os.path.join(self.__env.path, db_path)]

[Christian Boos]

Reproduced with pysqlite-2.4.1 as well.

[Christian Boos]

Fixed in r6484 for trunk and r6485 for 0.10.5.