Empty repository_dir may report Unsupported version control system "svn"

[Jeroen Ruigrok van der Werven]

On IRC someone had problems that Trac was reporting Unsupported version control system "svn".

The standard import test for svn worked without a glitch.

As it turns out repository_dir in trac.ini was empty. repository_type on the other hand was set to svn.

On 0.11 with no repository_dir set my browser sections does not get shown. So it would mean a backport of that detection/avoidance logic to the 0.10-stable branch.

[Jeroen Ruigrok van der Werven]

To be clearer:

With repository_dir not set, the user still gets a link to Browse Source, 0.11 does not do this.

So when the user clicks Browse Source Trac will throw the Unsupported version control system "svn" error.

[Christian Boos]

… so?

If this works fine in 0.11, just tell him to upgrade.

I see no point in creating a ticket for 0.10.5 for such a minor defect. There's no guarantee that this release will ever be made.

What needs to be done is to move the important defects from 0.10.5 to 0.11.1 and close some others as wontfix.

What could go in 0.10.5 at this point are:

• critical bug fixes if any
• security fixes
• maybe adaptation to newer external packages if needed (e.g. r6224)

So I'd say wontfix for this ticket, unless someone is willing to contribute a patch for this (but in my opinion, it's not worth the trouble).

[Jeroen Ruigrok van der Werven]

I merely logged this since it was the second instance in 1 week for this particular type of problem and the feedback from the system is misleading. This way at least we have a traceable document of the issue. Might just be enough to document it in the Faq/SVN section or some known caveat document for 0.10.x.

I have not yet looked at the code, might even be trivial to backport.

In the end I am fine with any solution as long as our userbase has a way to resolve their issue. I think we can both agree on that point?

[Christian Boos]

Trying once again with 0.10-stable shows that it works as expected: when repository_dir is commented out or left blank, the "Browse" tab doesn't appear and there's no error when the Subversion bindings are not installed.

Maybe the original issue was due to a repository_dir entry defined in the global trac.ini and the repository_dir entry in the environment's conf/trac.ini file was commented out instead of set to empty?