#6445 closed defect (fixed)
post-commit script example in trac-post-commit-hook is missing environment variable "TRAC_ENV"
| Reported by: | Owned by: | Christian Boos | |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.12-multirepos |
| Component: | version control | Version: | devel |
| Severity: | minor | Keywords: | trac-post-commit-hook multirepos |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
The example post-commit script in the trac-post-commit-hook is missing the TRAC_ENV variable. See patch.
Attachments (1)
Change History (10)
by , 17 years ago
comment:1 by , 17 years ago
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
comment:2 by , 17 years ago
BTW, do not forget to report the version of Trac you're using when you submit a new ticket.
comment:3 by , 17 years ago
| Resolution: | invalid |
|---|---|
| Status: | closed → reopened |
Please look at this patch again. The example shell script for Subversion needs TRAC_ENV, which is not assigned in the example in the comments. TRAC_ENV is used nowhere in the Python script.
I'm using Trac r6294.
comment:4 by , 17 years ago
| Priority: | normal → low |
|---|---|
| Severity: | normal → minor |
| Version: | → devel |
Yes, you're right.
comment:5 by , 17 years ago
| Keywords: | trac-post-commit-hook added |
|---|---|
| Milestone: | → 0.11.1 |
comment:6 by , 16 years ago
| Keywords: | multirepos added |
|---|---|
| Milestone: | 0.11-retriage → 0.12 |
This is fixed in the new source:sandbox/multirepos/contrib/trac-svn-hook.
comment:7 by , 15 years ago
| Priority: | low → normal |
|---|
To be done: finish the hooks, in particular write a trac-svn-hook.cmd.
comment:8 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
There's actually a more focused ticket for trac-svn-hook.cmd, #6370.
So I'm closing this one (new trac-svn-hook complete and hopefully clear about setting TRAC_ENV).
comment:9 by , 15 years ago
| Milestone: | 0.12 → 0.12-multirepos |
|---|
Not really: the comment section you're referring to explain how to get the environment variables from Subversion, i.e. how the Subversion server calls the hook script, passing the repository as the 1st argument and the revision as the 2nd argument.
TRAC_ENVneeds to be given to the Python hook script.However your patch refers to a shell script example that can be used to call the Python hook script in turn.