Edgewall Software
Modify ↓

Opened 17 years ago

Closed 17 years ago

#6245 closed enhancement (fixed)

[PATCH] render comment lines in svn:externals property correctly

Reported by: Dave Gynn <dgynn@…> Owned by: Christian Boos
Priority: normal Milestone: 0.11
Component: version control Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

svn:externals supports comment lines that start with the "#" character but the SubversionPropertyRenderer mangles them

the attached patch displays the comments normally

Attachments (1)

svn_externals_comments_render.diff​ (540 bytes ) - added by Dave Gynn <dgynn@…> 17 years ago.

Download all attachments as: .zip

Change History (5)

by Dave Gynn <dgynn@…>, 17 years ago

Attachment: svn_externals_comments_render.diff​ added

comment:1 by Christian Boos, 17 years ago

Milestone: → 0.11

Looks good, I'll test the patch, thanks!

comment:2 by Christian Boos, 17 years ago

I don't know … the line is still presented to the user. Wouldn't it be better to simply hide it? (it's commented out after all)

comment:3 by osimons <simon-code@…>, 17 years ago

I think the comment should be displayed. Common usecases are that it is either an actual comment providing information about some svn:externals definition, or it is a definition that has been disabled. Either way it is useful.

comment:4 by Christian Boos, 17 years ago

Resolution: → fixed
Status: new → closed

Ok, fine. Patch committed as r6102.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.