Edgewall Software
Modify ↓

Opened 17 years ago

Last modified 7 years ago

#6128 new enhancement

[Patch] Pagination for the Timeline

Reported by: Naoki Takezoe Owned by:
Priority: low Milestone: next-major-releases
Component: timeline Version: 0.10.4
Severity: normal Keywords: patch pagination performance
Cc: trac-ja@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Trac displays a lot of events as one page at the timeline. So sometimes it causes performance problems like the ticket report.

Attached patch provides the pagination for the Timeline (for 0.10.4).

Attachments (3)

timeline.zip​ (1.7 KB ) - added by Naoki Takezoe 17 years ago.
trac-0.11dev_r6303-timeline_paginate.patch​ (8.7 KB ) - added by trac-ja@… 17 years ago.
patch againsts source:trunk@6303​
trac-0.11b1-timeline_paginate.patch​ (9.6 KB ) - added by trac-ja@… 17 years ago.
Patch againsts Trac-0.11b1

Download all attachments as: .zip

Change History (16)

by Naoki Takezoe, 17 years ago

Attachment: timeline.zip​ added

comment:1 by sid, 17 years ago

This is possibly a duplicate of #215.

comment:2 by Naoki Takezoe, 17 years ago

Hmm… r4681 seems to paginate by the daysback.

But in my project, there are quite a lot of events in one day. So I think it's better to paginate by number of events than daysback.

comment:3 by Noah Kantrowitz, 17 years ago

Resolution: → duplicate
Status: new → closed

Old release branches are frozen, we only fix bugs, no new features.

comment:4 by Naoki Takezoe, 17 years ago

Sorry, I'll try to port my patch to trunk.

by trac-ja@…, 17 years ago

Attachment: trac-0.11dev_r6303-timeline_paginate.patch​ added

patch againsts source:trunk@6303​

comment:5 by trac-ja@…, 17 years ago

Cc: trac-ja@… added
Resolution: duplicate
Status: closed → reopened

I ported Takezoe's patch to trunk.

comment:6 by Christian Boos, 17 years ago

Milestone: → 0.12
Priority: normal → high

Looks good. Note the default_maxrows_rss options is still named 'default_maxrows'.

by trac-ja@…, 17 years ago

Attachment: trac-0.11b1-timeline_paginate.patch​ added

Patch againsts Trac-0.11b1

in reply to:  6 comment:7 by trac-ja@…, 17 years ago

Replying to cboos:

Looks good. Note the default_maxrows_rss options is still named 'default_maxrows'.

This patch has four options (two pairs of daysback and maxrows):

  • default_daysback
  • default_maxrows
  • default_daysback_rss
  • default_maxrows_rss

One pair is for HTML, and another is for RSS.

There should be separated, I think.

comment:8 by Christian Boos, 14 years ago

Keywords: pagination added
Priority: high → low

The patch probably needs to be refreshed for trunk.

comment:9 by figaro, 10 years ago

Keywords: performance added

comment:10 by Ryan J Ollos, 9 years ago

Owner: Christian Boos removed
Status: reopened → new

comment:11 by figaro, 9 years ago

Summary: Timeline Paginate Patch → [Patch] Pagination for the Timeline

comment:12 by figaro, 9 years ago

Keywords: patch added

comment:13 by Ryan J Ollos, 7 years ago

#8701 is related, requesting that the timeline show at least N entries, even if those entries are older than daysback.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.