#5803 closed defect (worksforme)
In Change History for ticket, no difference between a zero value and an empty value, always shows as "deleted"
| Reported by: | Owned by: | Jonas Borgström | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | ticket system | Version: | 0.10.3.1 |
| Severity: | normal | Keywords: | |
| Cc: | francois@… | Branch: | |
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
When I set a field to a value of '0' (a string with a zero), then the Change History section of the shows the value as "deleted" instead of showing "changed from 1.5 to 0." for example. This is a misleading for the user, especially when using custom fields for numeric values such as burn rate, for example for the burnrate plugins.
I am working on a patch on my installation, and I believe that this (very simple) patch could be accepted in the product. Your opinion ?
Attachments (3)
Change History (14)
by , 17 years ago
| Attachment: | field_with_zero_not_deleted.patch added |
|---|
by , 17 years ago
| Attachment: | field_with_zero_not_deleted.2.patch added |
|---|
Patch that fixes this issue (on 0.10.3.1)
follow-up: 5 comment:2 by , 17 years ago
Replying to anonymous:
+1
I had the same problem and tried your solution and it works. Now I have an other problem when I do a report, the value '0' is not displayed, there's a blank. Do you have any solution?
comment:3 by , 17 years ago
| Keywords: | verify added |
|---|---|
| Milestone: | → 0.11.1 |
We should verify whether the problem is still there in 0.11dev and if yes, adapt the patch to trunk.
comment:4 by , 17 years ago
I have to port some other work I have done to 0.11, so I will get to look at that in the next few week. I'll propose a patch for 0.11 if needed. The problem was in clearsilver, but it is possible that Genshi has a similar issue.
follow-up: 6 comment:5 by , 17 years ago
Replying to anonymous:
Replying to anonymous:
+1
I had the same problem and tried your solution and it works. Now I have an other problem when I do a report, the value '0' is not displayed, there's a blank. Do you have any solution?
Yes, I saw this problem; I'm adding a patch for it (for 0.10.3.1 but it shouldn't difficult to adapt it other 0.10.x releases)
by , 17 years ago
| Attachment: | patch_zero_in_reports.patch added |
|---|
additional patch for francois@nexb.com
comment:6 by , 17 years ago
Replying to francois@nexb.com:
Replying to anonymous:
Replying to anonymous:
+1
I had the same problem and tried your solution and it works. Now I have an other problem when I do a report, the value '0' is not displayed, there's a blank. Do you have any solution?
Yes, I saw this problem; I'm adding a patch for it (for 0.10.3.1 but it shouldn't difficult to adapt it other 0.10.x releases)
Thank you for your help, your patch works very well.
comment:7 by , 17 years ago
| Keywords: | verify removed |
|---|---|
| Milestone: | 0.11.1 |
| Resolution: | → wontfix |
| Status: | new → closed |
This behavior does no longer exist in trunk (0.11dev): Changing the keyword field + a custom field from some input to '0' gave this output:
- keywords 0 added; a_keyword removed
- test_field changed from a_word to 0
This will not be backported to 0.10, so I suppose it is a 'wontfix' for this ticket - although it obviously has been 'fixed' elsewhere.
comment:9 by , 17 years ago
| Resolution: | wontfix |
|---|---|
| Status: | closed → reopened |
Replying to cboos:
Don't you think worksforme would be more appropriate here?
Well, you tell me :-) I was (again) in doubt on what was correct… I'll go read TracTicketTriage again for the n-th time.
comment:11 by , 17 years ago
It's not an exact science ;-)
My feeling is that we should use:
- wontfix when the issue will not be addressed, for whatever reason
- worksforme when the issue has already been fixed at the time of the creation of the ticket, or has been fixed later on but as a side-effect (or when we don't bother looking up the exact changeset which fixed that issue on purpose ;-) )
Patch that fixes this issue (on 0.10.3.1)