Edgewall Software
Modify ↓

Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#5797 closed defect (fixed)

Expanding dirs in browser spin forever on error

Reported by: Tim Hatch Owned by: Tim Hatch
Priority: normal Milestone: 0.11
Component: version control/browser Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

The best way I can see around this is to replace $.get with $.ajax and use its richer interface to specify an error callback that replaces the expansion with (error) like the (empty dir) one does. Patch in a sec.

I think anyone would hit this if their 'net connection went down, but I specifically hit it with a NoSuchChangeset exception (which is served as a 404).

Attachments (1)

expand_catch_error.diff​ (2.0 KB ) - added by Tim Hatch 18 years ago.
Against r5879

Download all attachments as: .zip

Change History (6)

by Tim Hatch, 18 years ago

Attachment: expand_catch_error.diff​ added

Against r5879

comment:1 by Tim Hatch, 18 years ago

Owner: changed from Christian Boos to Tim Hatch

comment:2 by Tim Hatch, 18 years ago

Milestone: → 0.11
Resolution: → fixed
Status: new → closed

Fixed in r5890

comment:3 by theultramage, 18 years ago

Priority: normal → high
Resolution: fixed
Severity: normal → major
Status: closed → reopened

I'm reopening this, because r5890 broke the expanding dirs feature - at least on Opera and Internet Explorer (both latest update) they don't display anymore.

comment:4 by Tim Hatch, 18 years ago

Priority: high → normal
Resolution: → fixed
Severity: major → normal
Status: reopened → closed

I introduced a stray comma in r5890 which was breaking IE6, it's removed in r5904 which will hopefully fix the IE/Opera issue.

comment:5 by theultramage, 18 years ago

I confirm that it works on Opera again. Thank you for the fix.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Tim Hatch.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Tim Hatch to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.