Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

#5588 closed defect (fixed)

[PATCH] - <div id="help"> in Roadmap/Milestone is located outside content div.

Reported by: osimons <simon-code@…> Owned by: Christopher Lenz
Priority: normal Milestone: 0.11
Component: roadmap Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

I am customizing a number of help links (replacing the `<div id="help"> sections) by using Genshi matching in a site.html file.

In the various roadmap and milestone templates, this div section is located outside the main content div making them body-level tags - and different from where it is located in other modules such as wiki and search that I have transformed so far.

Enclosed is a patch against revision 5734 that moves </div> tags to locate the sections correctly.

Attachments (2)

roadmap_div_help-0.11dev-r5734.diff (2.5 KB ) - added by osimons <simon-code@…> 15 years ago.
Patch that moves closing </div> tags to properly locate the <div id="help"> section in roadmap/milestone module.
templates_div_help-0.11dev-r5734.diff (4.8 KB ) - added by osimons <simon-code@…> 15 years ago.
Been through all <div id="help"> sections, and also found the same behavior in report templates. Patch updated to include all templates where closing 'content' </div> needs to be moved.

Download all attachments as: .zip

Change History (3)

by osimons <simon-code@…>, 15 years ago

Patch that moves closing </div> tags to properly locate the <div id="help"> section in roadmap/milestone module.

by osimons <simon-code@…>, 15 years ago

Been through all <div id="help"> sections, and also found the same behavior in report templates. Patch updated to include all templates where closing 'content' </div> needs to be moved.

comment:1 by Christian Boos, 15 years ago

Resolution: fixed
Status: newclosed

Whereas one could argue about the optimal placement of the <div id="help"> (inside the <div id="content"> or outside, directly below the <body>), the more important thing is some kind of standardization. As other help links can often be found within the content anyway (like WikiFormatting links), I opted for your suggestion (and well, that was the path of least effort anyway ;-) ).

Patch applied in r5755.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christopher Lenz to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.