Opened 18 years ago
Closed 18 years ago
#5588 closed defect (fixed)
[PATCH] - <div id="help"> in Roadmap/Milestone is located outside content div.
| Reported by: | Owned by: | Christopher Lenz | |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.11 |
| Component: | roadmap | Version: | devel |
| Severity: | normal | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
I am customizing a number of help links (replacing the `<div id="help"> sections) by using Genshi matching in a site.html file.
In the various roadmap and milestone templates, this div section is located outside the main content div making them body-level tags - and different from where it is located in other modules such as wiki and search that I have transformed so far.
Enclosed is a patch against revision 5734 that moves </div> tags to locate the sections correctly.
Attachments (2)
Change History (3)
by , 18 years ago
| Attachment: | roadmap_div_help-0.11dev-r5734.diff added |
|---|
by , 18 years ago
| Attachment: | templates_div_help-0.11dev-r5734.diff added |
|---|
Been through all <div id="help"> sections, and also found the same behavior in report templates. Patch updated to include all templates where closing 'content' </div> needs to be moved.
comment:1 by , 18 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Whereas one could argue about the optimal placement of the <div id="help"> (inside the <div id="content"> or outside, directly below the <body>), the more important thing is some kind of standardization. As other help links can often be found within the content anyway (like WikiFormatting links), I opted for your suggestion (and well, that was the path of least effort anyway ;-) ).
Patch applied in r5755.
Patch that moves closing </div> tags to properly locate the <div id="help"> section in roadmap/milestone module.