Edgewall Software
Modify

Opened 13 years ago

Closed 13 years ago

#5422 closed defect (fixed)

relative links in report RSS break FF's reader

Reported by: bboisvert@… Owned by: Christian Boos
Priority: normal Milestone: 0.11
Component: report system Version:
Severity: minor Keywords:
Cc: Branch:
Release Notes:
API Changes:

Description

Report RSS format has root-relative links, which Firefox doesn't handle correctly. Other RSS feeds (timeline, ticket comments, etc) have absolute URLs, which work.

Attachments (1)

report_rss-r5572.diff (1.0 KB ) - added by Christian Boos 13 years ago.
Use absolute urls in report rss feed

Download all attachments as: .zip

Change History (7)

comment:1 by anonymous, 13 years ago

Component: generalreport system
Owner: changed from Jonas Borgström to Matthew Good

comment:2 by Christian Boos, 13 years ago

Milestone: 0.11
Owner: changed from Matthew Good to anonymous
Status: newassigned

Could you please test the attached patch? If that doesn't fix the issue, then please attach an example file containing the still broken output, thanks!

by Christian Boos, 13 years ago

Attachment: report_rss-r5572.diff added

Use absolute urls in report rss feed

comment:3 by bboisvert@…, 13 years ago

That patch errors with this message:

Trac detected an internal error:

UndefinedError: <Context report:6, ticket:1 <Request "GET /report/6">> has no member named "get_href"
 File "/usr/lib/python2.3/site-packages/Trac-0.11dev-py2.3.egg/trac/ticket/templates/report.rss", line 1, in  <Expression u'row.context.get_href(abs_href)'>  

I'm running 0.11dev, which was built from source:/trunk@5468. I don't have time to upgrade to the bleeding edge at the moment, so I can't test it there.

comment:4 by bboisvert@…, 13 years ago

Change of plans….please ignore my comment at 5:34.

I did get to do the upgrade to source:/trunk@5578 and the patch works like a charm.

comment:5 by Christian Boos, 13 years ago

Owner: changed from anonymous to Christian Boos
Status: assignednew

Ok, thanks for testing.

comment:6 by Christian Boos, 13 years ago

Resolution: fixed
Severity: normalminor
Status: newclosed

Patch applied in r5579.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.