Header logo on wrong position, when SEARCH_VIEW not activated

[jl]

The header logo is on the wrong position (crossing the wiki/timeline/roadmap/… -bar), when the SEARCH_VIEW permission is not available for the user. This happens not in version 0.10.4. My actual test version is 0.11dev-r5552.

[jl]

Wrong logo position

[anonymous]

Same error here, only I have disabled trac.search.web_ui entirely so same effect for all users. Using 0.11dev-r6038

[osimons]

Found it. It is a minor change from 0.10 that we no doudt didn't see the formatting consequences of. Basically, the search form consists of the <form> tag, and a <div> containing the textfield and button. In 0.10, we keep the form regardless, but don't show any fields - basically the search will not show, but the form 'lives' and takes up it's usual place in the page layout.

Here is a patch:

trac/templates/layout.html

@@ -43 +43 @@
           height="${chrome.logo.height or None}" width="${chrome.logo.width or None}" /></a>
         <h1 py:otherwise=""><a href="${chrome.logo.link}">${project.name}</a></h1>
       </div>
-      <form py:if="'SEARCH_VIEW' in perm" id="search"
-            action="${href.search()}" method="get"><div>
-        <label for="proj-search">Search:</label>
-        <input type="text" id="proj-search" name="q" size="18" accesskey="f" value="" />
-        <input type="submit" value="Search" />
-      </div></form>
+      <form id="search" action="${href.search()}" method="get">
+        <div py:if="'SEARCH_VIEW' in perm">
+          <label for="proj-search">Search:</label>
+          <input type="text" id="proj-search" name="q" size="18" accesskey="f" value="" />
+          <input type="submit" value="Search" />
+        </div>
+      </form>
       ${navigation('metanav')}
     </div>
     ${navigation('mainnav')}

If we're OK with restoring the 0.10 way of things, then I'll apply the patch.

[osimons]

Patch applied in [6278]. Closing.