Modify ↓
Opened 18 years ago
Closed 18 years ago
#5268 closed defect (fixed)
Browse source tree view causes Safari 2.x to crash
| Reported by: | Owned by: | Christian Boos | |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.11 |
| Component: | version control/browser | Version: | devel |
| Severity: | major | Keywords: | expander |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description (last modified by )
Trunk as of today causes Safari 2.x to crash when browsing source using the new dynamic tree view. It loads OK, but clicking on the arrow to unfold a folder causes Safari to crash and report the following error:
**********
Host Name: ######
Date/Time: 2007-05-05 19:41:20.734 +1000
OS Version: 10.4.9 (Build 8P2137)
Report Version: 4
Command: Safari
Path: /Applications/Safari.app/Contents/MacOS/Safari
Parent: WindowServer [65]
Version: 2.0.4 (419.3)
Build Version: 31
Project Name: WebBrowser
Source Version: 4190300
PID: 16254
Thread: 0
Exception: EXC_BAD_ACCESS (0x0001)
Codes: KERN_INVALID_ADDRESS (0x0001) at 0xbf7fffdc
Thread 0 Crashed:
0 com.apple.JavaScriptCore 0x952d54f7 match + 12
1 com.apple.JavaScriptCore 0x952d5679 match + 398
2 com.apple.JavaScriptCore 0x952d63d1 match + 3814
// snip: lines 1-2 repeated up to:
507 com.apple.JavaScriptCore 0x952d5679 match + 398
508 com.apple.JavaScriptCore 0x952d63d1 match + 3814
Thread 1:
0 libSystem.B.dylib 0x9000a457 mach_msg_trap + 7
1 libSystem.B.dylib 0x900677dd thread_suspend + 96
2 <<00000000>> 0x001ed836 0 + 2021430
Thread 2:
0 libSystem.B.dylib 0x9000a457 mach_msg_trap + 7
1 com.apple.CoreFoundation 0x9082c2b3 CFRunLoopRunSpecific + 2014
2 com.apple.CoreFoundation 0x9082bace CFRunLoopRunInMode + 61
3 com.apple.Foundation 0x9281ad3a -[NSRunLoop runMode:beforeDate:] + 182
4 com.apple.Foundation 0x9281ac36 -[NSRunLoop run] + 75
5 com.apple.WebKit 0x951c0529 +[WebFileDatabase _syncLoop:] + 198
6 com.apple.Foundation 0x927e52e0 forkThreadForFunction + 123
7 libSystem.B.dylib 0x90024987 _pthread_body + 84
Thread 3:
0 libSystem.B.dylib 0x9001a93c select + 12
1 libSystem.B.dylib 0x90024987 _pthread_body + 84
Thread 4:
0 libSystem.B.dylib 0x9000a457 mach_msg_trap + 7
1 com.apple.CoreFoundation 0x9082c2b3 CFRunLoopRunSpecific + 2014
2 com.apple.CoreFoundation 0x9082bace CFRunLoopRunInMode + 61
3 com.apple.Foundation 0x9281aa0f +[NSURLConnection(NSURLConnectionInternal) _resourceLoadLoop:] + 259
4 com.apple.Foundation 0x927e52e0 forkThreadForFunction + 123
5 libSystem.B.dylib 0x90024987 _pthread_body + 84
Thread 5:
0 libSystem.B.dylib 0x9000a457 mach_msg_trap + 7
1 com.apple.CoreFoundation 0x9082c2b3 CFRunLoopRunSpecific + 2014
2 com.apple.CoreFoundation 0x9082bace CFRunLoopRunInMode + 61
3 com.apple.Foundation 0x92841bc2 +[NSURLCache _diskCacheSyncLoop:] + 206
4 com.apple.Foundation 0x927e52e0 forkThreadForFunction + 123
5 libSystem.B.dylib 0x90024987 _pthread_body + 84
Thread 6:
0 libSystem.B.dylib 0x90025027 semaphore_wait_signal_trap + 7
1 com.apple.Foundation 0x9283b26c -[NSConditionLock lockWhenCondition:] + 39
2 com.apple.Syndication 0x9a7c5966 -[AsyncDB _run:] + 181
3 com.apple.Foundation 0x927e52e0 forkThreadForFunction + 123
4 libSystem.B.dylib 0x90024987 _pthread_body + 84
Thread 0 crashed with X86 Thread State (32-bit):
eax: 0x0122e7cc ebx: 0x952d54fc ecx: 0x00000006 edx: 0x1624f3b6
edi: 0x00000000 esi: 0x00000002 ebp: 0xbf800268 esp: 0xbf7fffe0
ss: 0x0000001f efl: 0x00010282 eip: 0x952d54f7 cs: 0x00000017
ds: 0x0000001f es: 0x0000001f fs: 0x00000000 gs: 0x00000037
Binary Images Description:
0x1000 - 0xdbfff com.apple.Safari 2.0.4 (419.3) /Applications/Safari.app/Contents/MacOS/Safari
0x3fb000 - 0x3fbfff org.xlife.InquisitorLoader 3.0 (41) /Users/tony/Library/InputManagers/Inquisitor/Inquisitor.bundle/Contents/MacOS/Inquisitor
0x575000 - 0x595fff org.xlife.InquisitorCore 3.0 (41) /Users/tony/Library/InputManagers/Inquisitor/Inquisitor.bundle/Contents/Resources/InquisitorCore.bundle/Contents/MacOS/InquisitorCore
0x7a5000 - 0x7a6fff com.bronsonbeta.HeyFoldersOverride 1.0 /User Applications/Hey Folders!.app/Contents/Resources/HeyFoldersOverride.bundle/Contents/MacOS/HeyFoldersOverride
0x1550c000 - 0x1550dfff com.apple.textencoding.unicode 2.1 /System/Library/TextEncodings/Unicode Encodings.bundle/Contents/MacOS/Unicode Encodings
0x1592b000 - 0x1593dfff com.apple.security.dotmacdl 1.1.1 (25435) /System/Library/Security/dotmacdl.bundle/Contents/MacOS/dotmacdl
0x15979000 - 0x1598afff com.apple.security.ldapdl 1.0.1 (24742) /System/Library/Security/ldapdl.bundle/Contents/MacOS/ldapdl
0x8fe00000 - 0x8fe4afff dyld 46.12 /usr/lib/dyld
0x90000000 - 0x90170fff libSystem.B.dylib /usr/lib/libSystem.B.dylib
0x901c0000 - 0x901c2fff libmathCommon.A.dylib /usr/lib/system/libmathCommon.A.dylib
0x901c4000 - 0x90201fff com.apple.CoreText 1.1.2 (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreText.framework/Versions/A/CoreText
0x90228000 - 0x902fefff ATS /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS
0x9031e000 - 0x90773fff com.apple.CoreGraphics 1.258.61 (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics
0x9080a000 - 0x908d2fff com.apple.CoreFoundation 6.4.7 (368.28) /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
0x90910000 - 0x90910fff com.apple.CoreServices 10.4 (???) /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices
0x90912000 - 0x90a05fff libicucore.A.dylib /usr/lib/libicucore.A.dylib
0x90a55000 - 0x90ad4fff libobjc.A.dylib /usr/lib/libobjc.A.dylib
0x90afd000 - 0x90b61fff libstdc++.6.dylib /usr/lib/libstdc++.6.dylib
0x90bd0000 - 0x90bd7fff libgcc_s.1.dylib /usr/lib/libgcc_s.1.dylib
0x90bdc000 - 0x90c4ffff com.apple.framework.IOKit 1.4.6 (???) /System/Library/Frameworks/IOKit.framework/Versions/A/IOKit
0x90c64000 - 0x90c76fff libauto.dylib /usr/lib/libauto.dylib
0x90c7c000 - 0x90f22fff com.apple.CoreServices.CarbonCore 682.21 /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore
0x90f65000 - 0x90fcdfff com.apple.CoreServices.OSServices 4.1 /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices
0x91005000 - 0x91043fff com.apple.CFNetwork 129.20 /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork
0x91056000 - 0x91066fff com.apple.WebServices 1.1.3 (1.1.0) /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/WebServicesCore.framework/Versions/A/WebServicesCore
0x91071000 - 0x910effff com.apple.SearchKit 1.0.5 /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit
0x91124000 - 0x91142fff com.apple.Metadata 10.4.4 (121.36) /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata
0x9114e000 - 0x9115cfff libz.1.dylib /usr/lib/libz.1.dylib
0x9115f000 - 0x912fefff com.apple.security 4.5.2 (29774) /System/Library/Frameworks/Security.framework/Versions/A/Security
0x913fc000 - 0x91404fff com.apple.DiskArbitration 2.1.1 /System/Library/Frameworks/DiskArbitration.framework/Versions/A/DiskArbitration
0x9140b000 - 0x91412fff libbsm.dylib /usr/lib/libbsm.dylib
0x91416000 - 0x9143cfff com.apple.SystemConfiguration 1.8.6 /System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration
0x9144e000 - 0x914c4fff com.apple.audio.CoreAudio 3.0.4 /System/Library/Frameworks/CoreAudio.framework/Versions/A/CoreAudio
0x91515000 - 0x91515fff com.apple.ApplicationServices 10.4 (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices
0x91517000 - 0x91542fff com.apple.AE 314 (313) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE
0x91555000 - 0x91629fff com.apple.ColorSync 4.4.9 /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSync.framework/Versions/A/ColorSync
0x91664000 - 0x916d7fff com.apple.print.framework.PrintCore 4.6 (177.13) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore
0x91705000 - 0x917aefff com.apple.QD 3.10.24 (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD
0x917d4000 - 0x9181ffff com.apple.HIServices 1.5.2 (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices
0x9183e000 - 0x91854fff com.apple.LangAnalysis 1.6.3 /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis
0x91860000 - 0x9187afff com.apple.FindByContent 1.5 /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/FindByContent.framework/Versions/A/FindByContent
0x91884000 - 0x918c1fff com.apple.LaunchServices 182 /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices
0x918d5000 - 0x918e1fff com.apple.speech.synthesis.framework 3.5 /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis
0x918e8000 - 0x91927fff com.apple.ImageIO.framework 1.5.4 /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/ImageIO
0x9193a000 - 0x919ecfff libcrypto.0.9.7.dylib /usr/lib/libcrypto.0.9.7.dylib
0x91a32000 - 0x91a48fff libcups.2.dylib /usr/lib/libcups.2.dylib
0x91a4d000 - 0x91a6bfff libJPEG.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libJPEG.dylib
0x91a70000 - 0x91acffff libJP2.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libJP2.dylib
0x91ae1000 - 0x91ae5fff libGIF.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libGIF.dylib
0x91ae7000 - 0x91b6bfff libRaw.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libRaw.dylib
0x91b6f000 - 0x91bacfff libTIFF.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libTIFF.dylib
0x91bb2000 - 0x91bccfff libPng.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib
0x91bd1000 - 0x91bd3fff libRadiance.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libRadiance.dylib
0x91bd5000 - 0x91cb3fff libxml2.2.dylib /usr/lib/libxml2.2.dylib
0x91cd0000 - 0x91cd0fff com.apple.Accelerate 1.3.1 (Accelerate 1.3.1) /System/Library/Frameworks/Accelerate.framework/Versions/A/Accelerate
0x91cd2000 - 0x91d60fff com.apple.vImage 2.5 /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vImage.framework/Versions/A/vImage
0x91d67000 - 0x91d67fff com.apple.Accelerate.vecLib 3.3.1 (vecLib 3.3.1) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/vecLib
0x91d69000 - 0x91dc2fff libvMisc.dylib /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvMisc.dylib
0x91dcb000 - 0x91deffff libvDSP.dylib /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvDSP.dylib
0x91df7000 - 0x92200fff libBLAS.dylib /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib
0x9223a000 - 0x925eefff libLAPACK.dylib /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libLAPACK.dylib
0x9261b000 - 0x92708fff libiconv.2.dylib /usr/lib/libiconv.2.dylib
0x9270a000 - 0x92787fff com.apple.DesktopServices 1.3.6 /System/Library/PrivateFrameworks/DesktopServicesPriv.framework/Versions/A/DesktopServicesPriv
0x927c8000 - 0x929f8fff com.apple.Foundation 6.4.8 (567.29) /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation
0x92b12000 - 0x92b29fff libGL.dylib /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib
0x92b34000 - 0x92b8cfff libGLU.dylib /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib
0x92ba0000 - 0x92ba0fff com.apple.Carbon 10.4 (???) /System/Library/Frameworks/Carbon.framework/Versions/A/Carbon
0x92ba2000 - 0x92bb2fff com.apple.ImageCapture 3.0.4 /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture
0x92bc1000 - 0x92bc9fff com.apple.speech.recognition.framework 3.6 /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition
0x92bcf000 - 0x92bd4fff com.apple.securityhi 2.0.1 (24742) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI
0x92bda000 - 0x92c6bfff com.apple.ink.framework 101.2.1 (71) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink
0x92c7f000 - 0x92c82fff com.apple.help 1.0.3 (32.1) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help
0x92c85000 - 0x92ca3fff com.apple.openscripting 1.2.5 (???) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting
0x92cb5000 - 0x92cbbfff com.apple.print.framework.Print 5.1 (192.3) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print
0x92cc1000 - 0x92d24fff com.apple.htmlrendering 66.1 (1.1.3) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HTMLRendering.framework/Versions/A/HTMLRendering
0x92d48000 - 0x92d89fff com.apple.NavigationServices 3.4.4 (3.4.3) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/NavigationServices.framework/Versions/A/NavigationServices
0x92db0000 - 0x92dbdfff com.apple.audio.SoundManager 3.9.1 /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CarbonSound.framework/Versions/A/CarbonSound
0x92dc4000 - 0x92dc9fff com.apple.CommonPanels 1.2.3 (73) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels
0x92dce000 - 0x930c3fff com.apple.HIToolbox 1.4.9 (???) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox
0x931c9000 - 0x931d4fff com.apple.opengl 1.4.16 /System/Library/Frameworks/OpenGL.framework/Versions/A/OpenGL
0x931d9000 - 0x931f4fff com.apple.DirectoryService.Framework 3.3 /System/Library/Frameworks/DirectoryService.framework/Versions/A/DirectoryService
0x93264000 - 0x93264fff com.apple.Cocoa 6.4 (???) /System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa
0x93266000 - 0x9391cfff com.apple.AppKit 6.4.8 (824.42) /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit
0x93c9d000 - 0x93d18fff com.apple.CoreData 91 (92.1) /System/Library/Frameworks/CoreData.framework/Versions/A/CoreData
0x93d51000 - 0x93e0bfff com.apple.audio.toolbox.AudioToolbox 1.4.5 /System/Library/Frameworks/AudioToolbox.framework/Versions/A/AudioToolbox
0x93e4e000 - 0x93e4efff com.apple.audio.units.AudioUnit 1.4.2 /System/Library/Frameworks/AudioUnit.framework/Versions/A/AudioUnit
0x93e50000 - 0x94011fff com.apple.QuartzCore 1.4.12 /System/Library/Frameworks/QuartzCore.framework/Versions/A/QuartzCore
0x94057000 - 0x94098fff libsqlite3.0.dylib /usr/lib/libsqlite3.0.dylib
0x940a0000 - 0x940dafff libGLImage.dylib /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLImage.dylib
0x940df000 - 0x940f5fff com.apple.CoreVideo 1.4 /System/Library/Frameworks/CoreVideo.framework/Versions/A/CoreVideo
0x9418d000 - 0x941cbfff com.apple.vmutils 4.0.2 (93.1) /System/Library/PrivateFrameworks/vmutils.framework/Versions/A/vmutils
0x9420f000 - 0x94220fff com.apple.securityfoundation 2.2.1 (28150) /System/Library/Frameworks/SecurityFoundation.framework/Versions/A/SecurityFoundation
0x9422e000 - 0x9426cfff com.apple.securityinterface 2.2.1 (27695) /System/Library/Frameworks/SecurityInterface.framework/Versions/A/SecurityInterface
0x94288000 - 0x94297fff libCGATS.A.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCGATS.A.dylib
0x9429e000 - 0x942a9fff libCSync.A.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCSync.A.dylib
0x942f5000 - 0x9430ffff libRIP.A.dylib /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libRIP.A.dylib
0x94795000 - 0x948dbfff com.apple.AddressBook.framework 4.0.4 (485.1) /System/Library/Frameworks/AddressBook.framework/Versions/A/AddressBook
0x94967000 - 0x94976fff com.apple.DSObjCWrappers.Framework 1.1 /System/Library/PrivateFrameworks/DSObjCWrappers.framework/Versions/A/DSObjCWrappers
0x9497d000 - 0x949a6fff com.apple.LDAPFramework 1.4.2 (69.1.1) /System/Library/Frameworks/LDAP.framework/Versions/A/LDAP
0x949ac000 - 0x949bbfff libsasl2.2.dylib /usr/lib/libsasl2.2.dylib
0x949bf000 - 0x949e4fff libssl.0.9.7.dylib /usr/lib/libssl.0.9.7.dylib
0x949f0000 - 0x94a0dfff libresolv.9.dylib /usr/lib/libresolv.9.dylib
0x94d0e000 - 0x94d32fff libcurl.3.dylib /usr/lib/libcurl.3.dylib
0x951be000 - 0x95250fff com.apple.WebKit 419 /System/Library/Frameworks/WebKit.framework/Versions/A/WebKit
0x952aa000 - 0x9532cfff com.apple.JavaScriptCore 418.3 /System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/JavaScriptCore.framework/Versions/A/JavaScriptCore
0x95365000 - 0x95644fff com.apple.WebCore 418.21 /System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/WebCore
0x957c3000 - 0x957e6fff libxslt.1.dylib /usr/lib/libxslt.1.dylib
0x9a7c3000 - 0x9a7fafff com.apple.Syndication 1.0.6 (54) /System/Library/PrivateFrameworks/Syndication.framework/Versions/A/Syndication
0x9a816000 - 0x9a828fff com.apple.SyndicationUI 1.0.6 (54) /System/Library/PrivateFrameworks/SyndicationUI.framework/Versions/A/SyndicationUI
Attachments (1)
Change History (11)
comment:1 by , 18 years ago
| Severity: | blocker → major |
|---|
comment:2 by , 18 years ago
| Keywords: | expander added |
|---|---|
| Milestone: | → 0.11 |
comment:3 by , 18 years ago
The good news is that it works fine in WebKit trunk. The bad news is, your mac-using base probably aren't going to be using that as their main browser until after October this year. Your call on disabling it, but I'll have a look at the js and see if there's anything obvious in there that wouldn't work in Safari 2.x.
Thanks for the speedy response!
comment:4 by , 18 years ago
The same crash occurs w/ OmniWeb as well (which uses an older release of the WebKit).
cboos:
- do not disable it for the webkit trunk, it works smoothly ;-)
- WebKit user agent string:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en) AppleWebKit/522+ (KHTML, like Gecko) Safari/419.3
- Safari 2.x user agent string:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en) AppleWebKit/419 (KHTML, like Gecko) Safari/419.3
- WebKit user agent string:
- Safari has not been ported to other platforms as far as I can tell, but the engine (WebKit) is. It might be worth giving a try to some versions of Konqueror as well, it might suffer from the same issue.
(cboos, can you look at the wiki syntax of my comment, it seems the wiki parser adds a list item where it should not, "In other words…")
comment:5 by , 18 years ago
| Status: | new → assigned |
|---|
Can you test this patch?
Index: browser.html
===================================================================
--- browser.html (revision 5345)
+++ browser.html (working copy)
@@ -18,7 +18,10 @@
})
<py:if test="dir">
- enableExpandDir($(this));
+ /* browsers using old WebKits have issues with expandDir... */
+ var webkit_rev = /AppleWebKit\/(\d+)/.exec(navigator.userAgentuser);
+ if ( !webkit_rev || (521 - webkit_rev[1]).toString()[0] == "-" )
+ enableExpandDir($(this));
</py:if>
<py:if test="file and file.annotate">
enableBlame("${href.changeset()}/", "${path}");
(Note the lame attempt at doing a "<" test without having to resort to a CDATA section :-) )
comment:6 by , 18 years ago
| Description: | modified (diff) |
|---|
I've attached a fix up for the proposed patch (typo in userAgent), works fine.
Note: the "Expand Directory" info tip still shows up and the expand dir icon still changes on hovering, but I don't think it is worth changing the template files and adding some extra code to fix up a bug that is not in Trac, but in Safari.
I'm +1 on commiting the patch - let's just hope we won't get too much "expand dir does not work" tickets ;-)
follow-ups: 8 9 comment:7 by , 18 years ago
comment:8 by , 18 years ago
Replying to cboos:
The Javascript code is now quite different in r5358, so I think it's worth trying once again with older webkits, before activating the check.
Unfortunately, it does not help: Omniweb and Safari keep crashing (I've flushed the cache to be sure the new Javascript has been reloaded).
comment:9 by , 18 years ago
comment:10 by , 18 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Thanks for the feedback manu, your updated patch was applied in r5369.
Note:
See TracTickets
for help on using tickets.
Looks like an infinite loop … no idea why this happens but it's true I didn't test on Safari (dumb question: is there any Windows or Linux port of this?), so I'll probably just disable this feature on Safari for now.