Edgewall Software
Modify

Opened 17 years ago

Closed 17 years ago

#4796 closed defect (fixed)

AttributeError: 'NoneType' object has no attribute 'rev'

Reported by: ismael@… Owned by: Christian Boos
Priority: high Milestone: 0.11
Component: version control/changeset view Version: devel
Severity: major Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

How to Reproduce

While doing a GET operation on /changeset/4822, Trac issued an internal error.

This is very strange:

But this is even more:

The svn log

------------------------------------------------------------------------
r4822 | ismael | 2007-02-18 17:26:41 -0200 (Sun, 18 Feb 2007) | 3 lines
Changed paths:
   M /initng-ifiles/trunk/initfiles/daemon/esound.ii
   M /initng-ifiles/trunk/initfiles/daemon/gdm.ii
   M /initng-ifiles/trunk/initfiles/daemon/instant-gdm.ii
   M /initng-ifiles/trunk/initfiles/daemon/jackd.ii
   M /initng-ifiles/trunk/initfiles/daemon/kdm.ii
   M /initng-ifiles/trunk/initfiles/daemon/mpd.ii
   M /initng-ifiles/trunk/initfiles/daemon/pbbuttonsd.ii
   M /initng-ifiles/trunk/initfiles/daemon/slmodemd.ii
   M /initng-ifiles/trunk/initfiles/daemon/timidity.ii
   M /initng-ifiles/trunk/initfiles/daemon/xdm.ii
   D /initng-ifiles/trunk/initfiles/system/alsasound.ii
   D /initng-ifiles/trunk/initfiles/system/exportfs.ii
   D /initng-ifiles/trunk/initfiles/system/faketty.ii
   D /initng-ifiles/trunk/initfiles/system/fbsplash.ii
   D /initng-ifiles/trunk/initfiles/system/firestarter.ii
   D /initng-ifiles/trunk/initfiles/system/guarddog.ii
   D /initng-ifiles/trunk/initfiles/system/iptables.ii
   D /initng-ifiles/trunk/initfiles/system/laptop-mode.ii
   D /initng-ifiles/trunk/initfiles/system/lm-sensors.ii
   D /initng-ifiles/trunk/initfiles/system/local.ii
   D /initng-ifiles/trunk/initfiles/system/nfs.ii
   D /initng-ifiles/trunk/initfiles/system/splashy.ii

 * Moved iptables, faketty, alsasound, firestarter, guarddog, fbsplash,
   lm-sensors, splashy, local, laptop-mode, nfs, and exportfs to service/

------------------------------------------------------------------------

Request parameters:

{'new': u'4822'}

System Information

Trac 0.11dev
Python 2.4.4 (#2, Jan 13 2007, 17:50:26)
[GCC 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)]
SQLite 2.8.17
pysqlite 1.0.1
Genshi 0.4dev-r494
Pygments 0.7dev-r2733
Subversion 1.4.2
SilverCity ?

Python Traceback

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 401, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 213, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/lib/python2.4/site-packages/trac/versioncontrol/web_ui/changeset.py", line 308, in process_request
    self._render_html(req, repos, chgset, restricted, xhr, data)
  File "/usr/lib/python2.4/site-packages/trac/versioncontrol/web_ui/changeset.py", line 563, in _render_html
    href = req.href.changeset(new_node.rev, new_node.path)
AttributeError: 'NoneType' object has no attribute 'rev'

Attachments (0)

Change History (6)

comment:1 by Christian Boos, 17 years ago

Milestone: 0.11
Priority: normalhigh

Thanks ismael, so it appears you have SQLite.

I think it would help to get the output of the following command:

sqlite $TRAC_ENV/db/trac.db 'select * from node_change where rev=4822'

comment:2 by anonymous, 17 years ago

Here's the output of sqlite trac.db 'select * from node_change where rev=4822':

4822|initng-ifiles/trunk/initfiles/daemon/esound.ii|F|E|initng-ifiles/trunk/initfiles/daemon/esound.ii|4547
4822|initng-ifiles/trunk/initfiles/daemon/gdm.ii|F|E|initng-ifiles/trunk/initfiles/daemon/gdm.ii|4547
4822|initng-ifiles/trunk/initfiles/daemon/instant-gdm.ii|F|E|initng-ifiles/trunk/initfiles/daemon/instant-gdm.ii|4547
4822|initng-ifiles/trunk/initfiles/daemon/jackd.ii|F|E|initng-ifiles/trunk/initfiles/daemon/jackd.ii|4547
4822|initng-ifiles/trunk/initfiles/daemon/kdm.ii|F|E|initng-ifiles/trunk/initfiles/daemon/kdm.ii|4547
4822|initng-ifiles/trunk/initfiles/daemon/mpd.ii|F|E|initng-ifiles/trunk/initfiles/daemon/mpd.ii|4547
4822|initng-ifiles/trunk/initfiles/daemon/pbbuttonsd.ii|F|E|initng-ifiles/trunk/initfiles/daemon/pbbuttonsd.ii|4771
4822|initng-ifiles/trunk/initfiles/daemon/slmodemd.ii|F|E|initng-ifiles/trunk/initfiles/daemon/slmodemd.ii|4547
4822|initng-ifiles/trunk/initfiles/daemon/timidity.ii|F|E|initng-ifiles/trunk/initfiles/daemon/timidity.ii|4560
4822|initng-ifiles/trunk/initfiles/daemon/xdm.ii|F|E|initng-ifiles/trunk/initfiles/daemon/xdm.ii|4560
4822|initng-ifiles/trunk/initfiles/system/alsasound.ii|F|D|initng-ifiles/trunk/initfiles/system/alsasound.ii|4821
4822|initng-ifiles/trunk/initfiles/system/exportfs.ii|F|D|initng-ifiles/trunk/initfiles/system/exportfs.ii|4821
4822|initng-ifiles/trunk/initfiles/system/faketty.ii|F|D|initng-ifiles/trunk/initfiles/system/faketty.ii|4821
4822|initng-ifiles/trunk/initfiles/system/fbsplash.ii|F|D|initng-ifiles/trunk/initfiles/system/fbsplash.ii|4821
4822|initng-ifiles/trunk/initfiles/system/firestarter.ii|F|D|initng-ifiles/trunk/initfiles/system/firestarter.ii|4821
4822|initng-ifiles/trunk/initfiles/system/guarddog.ii|F|D|initng-ifiles/trunk/initfiles/system/guarddog.ii|4821
4822|initng-ifiles/trunk/initfiles/system/iptables.ii|F|D|initng-ifiles/trunk/initfiles/system/iptables.ii|4821
4822|initng-ifiles/trunk/initfiles/system/laptop-mode.ii|F|D|initng-ifiles/trunk/initfiles/system/laptop-mode.ii|4821
4822|initng-ifiles/trunk/initfiles/system/lm-sensors.ii|F|D|initng-ifiles/trunk/initfiles/system/lm-sensors.ii|4821
4822|initng-ifiles/trunk/initfiles/system/local.ii|F|D|initng-ifiles/trunk/initfiles/system/local.ii|4821
4822|initng-ifiles/trunk/initfiles/system/nfs.ii|F|D|initng-ifiles/trunk/initfiles/system/nfs.ii|4821
4822|initng-ifiles/trunk/initfiles/system/splashy.ii|F|D|initng-ifiles/trunk/initfiles/system/splashy.ii|4821

comment:3 by Christian Boos, 17 years ago

Damn, that's exactly what it was supposed to be, so the error is not in the resync code. Thanks a lot for the feedback, I still need to find the time to reproduce this locally.

comment:4 by Christian Boos, 17 years ago

Milestone: 0.11
Resolution: worksforme
Status: newclosed

Hm, just went there … it works now!

I think I forgot to ask you the obvious question: what revision of Trac were you using? … and that must have been something between r4682 and r4687 (excluded).

My bad and sorry for the noise!

comment:5 by Christian Boos, 17 years ago

Milestone: 0.11
Resolution: worksforme
Status: closedreopened

Ah, http://www.initng.org/changeset/4822/initng-ifiles/trunk/initfiles/ is still problematic, so maybe there's still something to fix!

comment:6 by Christian Boos, 17 years ago

Resolution: fixed
Severity: criticalmajor
Status: reopenedclosed

Ok, there was a bug after all :-) Fixed in r4815.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.