Edgewall Software
Modify ↓

Opened 17 years ago

Closed 17 years ago

#4558 closed defect (fixed)

Import genshi.core.Attrs from genshi.core, not just genshi

Reported by: Manuzhai <manuzhai@…> Owned by: Christopher Lenz
Priority: normal Milestone: 0.11
Component: general Version: devel
Severity: trivial Keywords: genshi
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

In trac.mimeview.tests.api, Trac imports Attrs straight from genshi. However, with a 0.3.x version of Genshi (the latest version available from CheeseShop), Attrs isn't yet present in genshi.core.all, so that this import fails. Instead, Trac should import Attrs from genshi.core, which works on pre-0.4 Genshi. I'll add a patch in a minute.

(This is obviously only a problem when running the tests.)

Attachments (1)

fix-attrs-import.diff​ (668 bytes ) - added by Manuzhai 17 years ago.
Fix for this issue.

Download all attachments as: .zip

Change History (3)

by Manuzhai, 17 years ago

Attachment: fix-attrs-import.diff​ added

Fix for this issue.

comment:1 by Christopher Lenz, 17 years ago

Owner: changed from Christian Boos to Christopher Lenz
Status: new → assigned

Good catch, I'll apply the patch.

comment:2 by Christopher Lenz, 17 years ago

Resolution: → fixed
Status: assigned → closed

Patch applied in [4594]. Thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christopher Lenz to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.