Edgewall Software
Modify

Opened 13 years ago

Last modified 4 months ago

#4519 new enhancement

[PATCH] Feature: component owner ticket notification

Reported by: jenalias@… Owned by:
Priority: normal Milestone: next-dev-1.5.x
Component: notification Version: 0.10.3
Severity: normal Keywords: patch notification
Cc: Christian Boos, webkontakt@…, pierrega@…, leho@… Branch:
Release Notes:

Allow component owner to subscribe to notifications.

API Changes:

Description (last modified by Emmanuel Blot)

The following patch allows for component owner notification of ticket updates (even when the ticket is assigned to a different user than the component owner). This feature must be enabled in the trac.ini file with a line like this:

[notification]
always_notify_component_owner = true

We've been using this patch with Trac 0.10 and it has been working fine.

I made the patch against this trunk file: http://svn.edgewall.org/repos/trac/trunk/trac/ticket/notification.py

Let me know if there are any problems with the patch and I'll be happy to address them. Thanks for your consideration.

Attachments (1)

component_owner_patch.diff (1.6 KB ) - added by jenalias@… 13 years ago.
Patch to allow for component owner notification of ticket changes

Download all attachments as: .zip

Change History (21)

by jenalias@…, 13 years ago

Attachment: component_owner_patch.diff added

Patch to allow for component owner notification of ticket changes

comment:1 by Emmanuel Blot, 13 years ago

Description: modified (diff)
Keywords: notification added

I'm not sure whether it is worth applying the patch as we really need to reconsider the way users get notified (there are several tickets about this topic, with one of them that propose to get rid of the always_notify_* options).

Anyway the option itself (notification of the component owner) should be considered in the new notification 'engine'

comment:2 by jenalias@…, 13 years ago

Sounds good to me. I know notification of the component owner has been very useful for us. Any method of implementation would be great.

comment:3 by Christian Boos, 13 years ago

Component: ticket systemnotification
Milestone: 0.12
Owner: changed from Jonas Borgström to Emmanuel Blot

Supersedes #3709: when implementing notification to owner, we should inform the old owner about ownership changes (the proposed patch doesn't seem to take care of this).

comment:4 by Christian Boos, 12 years ago

#6338 also requested that the old owner should be notified after change of ticket ownership.

comment:5 by webkontakt@…, 12 years ago

Cc: Christian Boos webkontakt@… added

Is #2311 also fixed with this patch? Seems to be duplicate then.

But does it really last until 0.12 until this (small, but fatal) bug will officially be fixed? It is fairly crucial for a productive workflow, and the bug is reported since years.

comment:6 by Christian Boos, 12 years ago

Yes, it looks like #2311 could be fixed the "brute force" way by this patch, but it's not a duplicate, as #2311 should work without forcing the owner to be always notified.

As for having to wait for 0.12: if someone (anyone) updates the patch for 0.11 and we (the trac team) approve the feature, this can go in 0.11.1, as this ticket falls into the "minor improvements" category.

comment:7 by pierrega@…, 11 years ago

Cc: pierrega@… added

Hello,

I'm trying to use this patch with 0.11 and the component owner does not receive email. Since I have no experience with python, is there anything I have to do other than modifying the Python25\Lib\site-packages\trac\ticket\notification.py file and adding a line in the the trac.ini file? I'm running tracd, what can I do to debug this?

Thanks!

comment:8 by anonymous, 10 years ago

In Looks like, in 0.11.1, the old component owner continues to be notified on all activity on the ticket.

So let's say the ticket gets created in the incorrect component. As owner of incorrect component I assign it to correct component. I then continue to be emailed all activity on this ticket even though I an not ticket owner, reporter or cc.

comment:9 by anonymous, 10 years ago

The bug reported by anonymous 8 months ago is still present. Assigning ticket to correct owner results in notifications still being sent to the owner of the old component.

comment:10 by anonymous, 9 years ago

I like this feature. Hope this patch can be accepted.

comment:11 by Peter Suter, 5 years ago

changeset:a419627eb162/psuter.hg (from log:psuter.hg@T11870_optional_subscribers in #11870) implements this feature. It would be enabled by default in the new trac.ini section from #11875:

[notification-subscriber]
always_notify_component_owner = TicketComponentOwnerSubscriber

Or users can (un-)subscribe in their notification preferences.

comment:12 by lkraav <leho@…>, 5 years ago

Cc: leho@… added

comment:13 by Peter Suter, 5 years ago

Milestone: next-major-releases1.1.5
Owner: changed from Emmanuel Blot to Peter Suter
Release Notes: modified (diff)
Status: newassigned

comment:14 by Ryan J Ollos, 5 years ago

Milestone: 1.1.51.1.6

comment:15 by Ryan J Ollos, 4 years ago

Milestone: 1.1.61.1.7

comment:16 by Ryan J Ollos, 4 years ago

Milestone: 1.1.71.2

Milestone renamed

comment:17 by Ryan J Ollos, 4 years ago

Milestone: 1.2next-dev-1.3.x

Moving tickets out of milestone:1.2. Please move back if you intend to complete the work within the next several weeks.

in reply to:  11 comment:18 by Peter Suter, 4 years ago

Owner: Peter Suter removed
Status: assignednew

Replying to psuter:

changeset:a419627eb162/psuter.hg (from log:psuter.hg@T11870_optional_subscribers in #11870) implements this feature. It would be enabled by default in the new trac.ini section from #11875:

[notification-subscriber]
always_notify_component_owner = TicketComponentOwnerSubscriber

Or users can (un-)subscribe in their notification preferences.

I still think this makes sense, but sadly don't seem to have enough time to pursue it further. Feel free take over.

comment:19 by figaro, 4 years ago

Keywords: patch added

comment:20 by Ryan J Ollos, 4 months ago

Milestone: next-dev-1.3.xnext-dev-1.5.x

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned. Next status will be 'new'.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.