Edgewall Software
Modify

Opened 13 years ago

Closed 5 years ago

Last modified 6 months ago

#2311 closed defect (fixed)

No notification email on owner change for the old owner

Reported by: webkontakt@… Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.2
Component: notification Version: 0.9
Severity: major Keywords: notification email
Cc: webkontakt@…, shishz@…, greg@…
Release Notes:

Send notification to previous owner when ticket owner is changed.

API Changes:

Description

If you change the owner of a ticket, the old owner is not notified by email.

Changing the CC field, however, invokes notification also to those removed from CC. Owner changes should do as well.

Attachments (0)

Change History (32)

comment:1 Changed 13 years ago by anonymous

Component: generalticket system

comment:2 Changed 13 years ago by anonymous

Cc: webkontakt@… added

comment:3 Changed 13 years ago by Christopher Lenz

Milestone: 0.9.11.0

comment:4 Changed 13 years ago by anonymous

Cc: shishz@… added

comment:5 Changed 13 years ago by anonymous

Keywords: notification email added

comment:6 Changed 10 years ago by Christian Boos

Component: ticket systemnotification

comment:7 Changed 9 years ago by Christian Boos

Milestone: 1.0unscheduled

Milestone 1.0 deleted

comment:8 Changed 8 years ago by Remy Blank

Milestone: triagingnext-major-0.1X
Owner: changed from Jonas Borgström to Remy Blank

comment:9 Changed 8 years ago by tsetliff@…

Our team would really like this feature. Please add me to the CC list.

comment:10 Changed 8 years ago by Ryan J Ollos <ryano@…>

Cc: ryano@… added

comment:11 Changed 8 years ago by greg@…

Cc: greg@… added

comment:12 Changed 8 years ago by get@…

same on 0.12

comment:13 Changed 8 years ago by anonymous

Is there any solution for this? I also need notification for old_owner

comment:14 Changed 7 years ago by Remy Blank

Owner: Remy Blank deleted

Refocusing.

comment:15 Changed 6 years ago by Steffen Hoffmann

The same issue (th:#6452) has been fixed now for th:AnnouncerPlugin in th:r12333.

comment:16 Changed 6 years ago by anonymous

Severity: minormajor

I recently upgraded to Trac 1.0 - and I was shocked to notice that a workflow critical bug like this is still not fixed. To my understanding, it's just sending out one single additional email. I reported this bug in 2005(!), and it is "new", and not assigned to anyone.

Is there anything one could do to bring this up again? This behavior is seriously affecting our productivity.

comment:17 Changed 6 years ago by anonymous

Milestone: next-major-releases1.0.1

I think this should be fixed in the next version. Hope you don't disagree.

comment:18 Changed 6 years ago by Remy Blank

Milestone: 1.0.1next-major-releases

Please don't change milestones without a good reason (no, "I want it and it's been open for 7 yeary" isn't; a patch might be). Thanks.

comment:19 Changed 6 years ago by Ryan J Ollos <ryan.j.ollos@…>

The patch in 25165a45 causes the previous owner to be notified when a ticket is reassigned. This was implemented by patterning the change after the way that prev_cc is handled: populating the field in _notify and then passing the value of the field as a parameter to the get_ticket_notification_recipients method.

The patch in bcd8df9a implements the same change in a different way, by isolating all of work in populating the recipients list to the get_ticket_notification_recipients method. I tend to think this leads to more readable code.

Neither patch causes the previous owner to be notified in the case of batch modification, and a similar pre-existing problem is that members removed from the CC list are not notified when the ticket is batch modified. It looks like the way to fix that issue is to pass the modtime to BatchTicketNotifyEmail.notify. The second of the two patches will probably make this problem easier to fix.

Last edited 5 years ago by Ryan J Ollos (previous) (diff)

comment:20 Changed 5 years ago by Ryan J Ollos

Cc: ryano@… removed
Milestone: next-major-releasesnext-stable-1.0.x
Owner: set to Ryan J Ollos
Status: newassigned

comment:21 Changed 5 years ago by Ryan J Ollos

Milestone: next-stable-1.0.x1.0.3

comment:22 Changed 5 years ago by Ryan J Ollos

Proposed changes can be found in log:rjollos.git:t2311.2. The intention is to only change the API in a way that is backwards compatible. Some of my earlier proposed changes would have changed the API in a non-backwards compatible way.

comment:23 Changed 5 years ago by Ryan J Ollos

The unit tests may need some adjustment for execution on Windows in order to avoid the problems described in #11301 and comment:68:ticket:5658.

comment:24 Changed 5 years ago by Ryan J Ollos

I'm working on parsing the monolithic changesets and adding more tests, and should have revised changes posted tomorrow.

comment:25 Changed 5 years ago by Ryan J Ollos

Some refactoring was committed to 1.0-stable in [12384:12386] and merged to trunk in [12387].

comment:26 Changed 5 years ago by Ryan J Ollos

Milestone: 1.0.31.0.2

Notification test cases refactored and extended in [12569]. Minor issue fixed in [12570]. Merged to trunk in [12571:12572].

comment:27 in reply to:  23 Changed 5 years ago by Ryan J Ollos

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Replying to rjollos:

The unit tests may need some adjustment for execution on Windows in order to avoid the problems described in #11301 and comment:68:ticket:5658.

I forgot about this potential issue. Jun, could you let me know if you spot any test failures on Windows?

Committed to 1.0-stable in [12580:12581]. Merged to trunk in [12582:12583].

comment:28 Changed 4 years ago by Peter Suter

See also #11533.

comment:29 Changed 6 months ago by Ryan J Ollos

r12569 removed the usage of trac.tests.notification.smtp_address. It is proposed for removal in pull request 20. The function uses an undefined variable start. Should we just remove the function, or deprecated it for removal in 1.5.1? It's possible some plugin is using it, but I think probably unlikely.

Last edited 6 months ago by Ryan J Ollos (previous) (diff)

comment:30 Changed 6 months ago by Tim Graham <timograham@…>

Can a plugin use a function trac.tests? Looking at my install of Trac, I don't see any test packages.

comment:31 in reply to:  30 Changed 6 months ago by Ryan J Ollos

Replying to Tim Graham <timograham@…>:

Can a plugin use a function trac.tests? Looking at my install of Trac, I don't see any test packages.

It cannot, good point. The test API functions and classes can be found in test.py files. We might consider moving some of the notification test API to trac/notification/test.py.

comment:32 Changed 6 months ago by Ryan J Ollos

comment:29 changes committed to trunk in r16680.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.