Edgewall Software
Modify

Opened 18 years ago

Closed 18 years ago

#4383 closed enhancement (fixed)

CORE - Loader should load single-file plugins after egg plugins

Reported by: ilias@… Owned by: Christopher Lenz
Priority: normal Milestone: 0.11
Component: general Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

The trac loader should load single-file plugins after the egg-plugins.

Single-File plugins rely more on egg-plugins than egg-plugins on single-file-plugins.

see example thread .

related ticket: #4317

Attachments (0)

Change History (4)

comment:1 by Noah Kantrowitz <coderanger@…>, 18 years ago

If any dependency is required, do not use a single-file plugin. The requirement should be documented in a way Trac (and setuptools) can see, which requires an egg. Using setuptools is not hard enough that it warrants additional hackery around the single-file system IMO. Propose a wontfix for this.

in reply to:  1 comment:2 by ilias@…, 18 years ago

Replying to Noah Kantrowitz <coderanger@yahoo.com>:

If any dependency is required, do not use a single-file plugin. The requirement should be documented in a way Trac (and setuptools) can see, which requires an egg. Using setuptools is not hard enough that it warrants additional hackery around the single-file system IMO. Propose a wontfix for this.

Single-file "system"? - what system? there's just a piece of draft-code.

Keep things complicated, thus users struggle even more and need the expertise of the team members.

"hackery"? - no hackery needed:

simply move this code block (single-file loader):

source:trunk/trac/loader.py@3557#L43

after this one (egg loader):

source:trunk/trac/loader.py@3557#L62

To have a more logical plugin-type-load-order (single-file after egg)

comment:3 by Christopher Lenz, 18 years ago

Milestone: 0.11
Owner: changed from Jonas Borgström to Christopher Lenz
Status: newassigned

It certainly makes sense to load single-file plugins after eggs.

comment:4 by Matthew Good, 18 years ago

Resolution: fixed
Status: assignedclosed

This was fixed in r4633.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christopher Lenz to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.